Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-backup): Attribute BackupVault.props.backupVaultName fails a validation #22161

Conversation

heyosi
Copy link

@heyosi heyosi commented Sep 21, 2022

…lidation when used with parameters #21735


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 21, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team September 21, 2022 05:56
@github-actions github-actions bot added the p2 label Sep 21, 2022
@heyosi heyosi changed the title fix(aws-backup) Attribute BackupVault.props.backupVaultName fails a va… fix(aws-backup) Attribute BackupVault.props.backupVaultName fails a validation Sep 21, 2022
@@ -291,6 +291,21 @@ test('import from name', () => {
}));
});

test('import from parameter', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fromBackupVaultName doesn't hit the code that you are updating. The test needs to be something like

// WHEN
  const vaultName = Fn.importValue('VaultName');
  new BackupVault(stack, 'Vault', {
    backupVaultName: vaultName,
  });

  // THEN
  Template.fromStack(stack).hasResourceProperties('AWS::Backup::BackupVault', {
    BackupVaultName: {
      'Fn::ImportValue': 'VaultName',
    },
  });

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @corymhall , I fix the test case as your comment.
Please review it again, thanks.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@mergify mergify bot dismissed corymhall’s stale review October 13, 2022 01:48

Pull request has been modified.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@heyosi heyosi changed the title fix(aws-backup) Attribute BackupVault.props.backupVaultName fails a validation fix(aws-backup): Attribute BackupVault.props.backupVaultName fails a validation Oct 13, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a30bf66
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@Naumel Naumel added the @aws-cdk/aws-backup Related AWS Backup label Oct 13, 2022
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the PR linter, this needs an integration test.

Additionally, please make sure that your PR body describes the problem the PR is solving, and the design approach and alternatives considered. Explain why the PR solves the problem. A link to an issue is helpful, but does not replace an explanation of your thought process (See Contributing Guide, Pull Requests).

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Nov 17, 2022
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-backup Related AWS Backup closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants