-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@aws-cdk/aws-servicecatalogappregistry-alpha: Using Fn::Join with Name
attribute in AWS::ServiceCatalogAppRegistry::Application
generates Outputs
that is not deployable
#23641
Labels
@aws-cdk/aws-servicecatalogappregistry
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
Comments
knihit
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Jan 11, 2023
knihit
changed the title
@aws-cdk/aws-servicecatalogappregistry-alpha: Using Fn::Join with
@aws-cdk/aws-servicecatalogappregistry-alpha: Using Fn::Join with Jan 11, 2023
Name
attribute in AWS::ServiceCatalogAppRegistry::Application
generates a CfnOutput that is not deployableName
attribute in AWS::ServiceCatalogAppRegistry::Application
generates Outputs
that is not deployable
I am currently able to work around the problem with the following escape hatch
|
3 tasks
mergify bot
pushed a commit
that referenced
this issue
Jan 12, 2023
As a customer, if I want to generate my application name from dynamic parameters then `CfnOutput` description for Application manager url is in undeployable state as `Description` only supports string. This fixes #23641 ### All Submissions: * [ X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-servicecatalogappregistry
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
Describe the bug
Using
Fn.join
inapplicationName
attribute when creatingApplication
using https://docs.aws.amazon.com/cdk/api/v2/docs/@aws-cdk_aws-servicecatalogappregistry-alpha.Application.html to generateAWS::ServiceCatalogAppRegistry::Application
also generates generates aDescription
inOutputs
that is not deployable.Expected Behavior
Because the
applicationName
is dynamic, do not use it forDescription
forOutputs
Current Behavior
The above code also generates
Outputs
Because the
Description is not a string
, the stack becomes undeployableReproduction Steps
Refer method
createAppForAppRegistry
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.59.0
Framework Version
2.59.0
Node.js Version
16.16.0
OS
Ventura (Mac OSX)
Language
Typescript
Language Version
4.7.4
Other information
No response
The text was updated successfully, but these errors were encountered: