Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(servicecatalogappregistry): outputs are not deployable #23652

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

santanugho
Copy link
Contributor

As a customer, if I want to generate my application name from dynamic parameters then CfnOutput description for Application manager url is in undeployable state as Description only supports string.
This fixes #23641

All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 11, 2023

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Jan 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 11, 2023 21:27
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@santanugho santanugho changed the title fix(servicecatalogappregistry) : Fixing dynamic description bug fix(servicecatalogappregistry): Fixing dynamic description bug Jan 11, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 11, 2023 21:41

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@rix0rrr rix0rrr changed the title fix(servicecatalogappregistry): Fixing dynamic description bug fix(servicecatalogappregistry): outputs are not deployable Jan 12, 2023
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha. It seems that the description field of an output may not contain tokens.

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6208b23
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit fa9eef0 into aws:main Jan 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2
Projects
None yet
4 participants