-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(provider-framework): (lambda runtime still using NODEJS_14) #25940
Labels
@aws-cdk/aws-lambda
Related to AWS Lambda
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Comments
alexherriott
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Jun 12, 2023
peterwoodworth
added
p2
effort/small
Small work item – less than a day of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Jun 12, 2023
Thanks for the report 👍🏻 |
mergify bot
pushed a commit
that referenced
this issue
Jun 20, 2023
Remove some leftover usage of NODE_14_X in custom resources vended in aws-cdk-lib. Changed to using the default runtime for the region. Closes #25940 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-lambda
Related to AWS Lambda
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Describe the bug
as part of release 2.77.0 lambdas were updated from nodejs14 to nodejs 16.
https://github.com/aws/aws-cdk/releases/tag/v2.77.0
however it seems that some were missed - https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/custom-resources/lib/provider-framework/provider.ts
nodejs_14 is still being used
Expected Behavior
nodejs_16 to be used for all CDK generated lambdas since release 2.77.0
Current Behavior
NODEJS_14 is still used in some cases
Reproduction Steps
deploy CDK which uses custom provider.
Possible Solution
update all lambdas so they do not use NODEJS_14
Additional Information/Context
No response
CDK CLI Version
2.77.0
Framework Version
No response
Node.js Version
16.20.0
OS
Ubuntu standard:6.0
Language
Typescript
Language Version
Typescript 4.9.4
Other information
No response
The text was updated successfully, but these errors were encountered: