fix: remaining usage of node 14 #25995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some leftover usage of NODE_14_X in custom resources vended in aws-cdk-lib. Changed to using the default runtime for the region.
|
|
aws-cdk-automation
previously requested changes
Jun 15, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
github-actions
bot
added
bug
MrArnoldPalmer
added
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
corymhall
approved these changes
Jun 20, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
to cdklabs/awscdk-asset-kubectl
that referenced
this pull request
Jun 5, 2024
- Helm Version: 3.15.1 - Kubectl Version: 1.30.0 （current version in [eks kubectl download page](https://docs.aws.amazon.com/eks/latest/userguide/install-kubectl.html)) - deprecating `nodejs14.x` and bumps the cdkVersion to 2.85.0 which includes aws/aws-cdk#25995 - deprecating python3.7 from integ test Fixes #838
mergify bot
pushed a commit
to cdklabs/awscdk-asset-kubectl
that referenced
this pull request
Jun 5, 2024
…nd remove deprecated python3.7 and nodejs14.x runtimes (#623) Similar to #546, this PR adds kubectl 1.29.4 and Helm 3.14.4 security patch https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.29.md#changelog-since-v1293 https://github.com/helm/helm/releases/tag/v3.14.4 Fixes [#588](#588). Fixes [#752](#752). Removes the EOL python3.7 runtime in the integ test and upgrade nodejs14.0 to nodejs16.0 used in custom resource provider by upgrading aws-cdk-lib from 2.28.0 to 2.85.0 in the current branch, which addresses the usage of node 14 [#25995](aws/aws-cdk#25995)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some leftover usage of NODE_14_X in custom resources vended in
aws-cdk-lib. Changed to using the default runtime for the region.
Closes #25940
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license