Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-cdk-lib/aws-ec2): (Request to update Windows Version enum list) #27019

Closed
2 tasks
aashishgk7760 opened this issue Sep 5, 2023 · 4 comments · Fixed by #27042
Closed
2 tasks

(aws-cdk-lib/aws-ec2): (Request to update Windows Version enum list) #27019

aashishgk7760 opened this issue Sep 5, 2023 · 4 comments · Fixed by #27042
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@aashishgk7760
Copy link

Describe the feature

As per latest version of the CDK 2.94.0 (build 987c329) , whenever we are creating a Windows instance , there are few AMI version which are not available in the list of enums https://github.com/aws/aws-cdk/tree/main/packages/aws-cdk-lib/aws-ec2/lib/windows-versions.ts.

Example : we don't have the Microsoft Windows Server 2019 Full Locale English with SQL Standard 2019 AMI provided by Amazon enum value.

Use Case

Instead of using LookupMachineImage , if we can have the updated list ,its easier to manage by directly referring to enum value.

Proposed Solution

Add a Enum value WINDOWS_SERVER_2019_ENGLISH_FULL_SQL_2019_Standard

example:

export enum WindowsVersion {

WINDOWS_SERVER_2019_ENGLISH_FULL_SQL_2019_Standard : ''Windows_Server-2019-English-Full-SQL_2019_Standard'
}

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

CDK 2.94.0 (build 987c329

Environment details (OS name and version, etc.)

Mac OS

@aashishgk7760 aashishgk7760 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2023
@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Sep 5, 2023
@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2023
@khushail
Copy link
Contributor

khushail commented Sep 5, 2023

Thanks @aashishgk7760 for submitting this feature request.

@msambol
Copy link
Contributor

msambol commented Sep 6, 2023

@khushail please assign me

@msambol
Copy link
Contributor

msambol commented Sep 6, 2023

@khushail / @mrgrain – There are quite a few missing from the file compared to what's returned by the CLI:

aws ssm get-parameters-by-path --path "/aws/service/ami-windows-latest" --region us-east-1 | jq '.Parameters | .[] | .Name' | grep Windows_Server

97 by my count. Do you want me to add them all?

@mergify mergify bot closed this as completed in #27042 Oct 11, 2023
mergify bot pushed a commit that referenced this issue Oct 11, 2023
I took the output of the command below and found the missing ones by diffing this [file](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/windows-versions.ts).

```bash
aws ssm get-parameters-by-path --path "/aws/service/ami-windows-latest" --region us-east-1 | jq '.Parameters | .[] | .Name' | grep Windows_Server
```

Closes #27019.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants