-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ec2): update Windows version enum list #27042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Values missing after a more recent check:
Windows_Server-2022-English-Core-EKS_Optimized-1.28
Windows_Server-2022-English-Full-EKS_Optimized-1.28
Windows_Server-2012_RTM-English-Full-Base
Windows_Server-2019-English-Full-SQL_2019_Standard
Windows_Server-2012_R2_RTM-English-Full-Base
Windows_Server-2019-English-Full-EKS_Optimized-1.28
Windows_Server-2019-English-Full-SQL_2019_Standard
Windows_Server-2019-English-Core-EKS_Optimized-1.28
I think it would be useful to keep together and order at least the EKS_Optimized
by version number to improve a bit this file's readability and organization.
Anyway, the ideal solution for keeping this file more organized and also allowing users to define the latest versions without having to wait for a lib update is to refactor the enum
to an enum-like class
.
I don't know if this is possible given that it will probably block the deployment for the changes in the interface declaration (may be worth investigating).
e0ca1af
to
57c8579
Compare
@lpizzinidev I added the missing ones and organized EKS optimized and then by year. |
@lpizzinidev I'm getting this?
Didn't change anything significant, not sure what that's about?? |
@msambol |
921e8c1
to
97c5476
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thank you @msambol for your contribution and thank you @lpizzinidev for reviewing this PR.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
I took the output of the command below and found the missing ones by diffing this file.
Closes #27019.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license