-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(dynamodb): Dynamo TableV2 does not support tagging replicas #27146
Comments
Hi @mikevec23 , looks like your request is similar to this one - #14943. However there are open issues with CfnGlobalTable. However if you feel like its not the same you are asking for, please feel free to share more insights into what is expected. |
@khushail Similar but not the same. Both #14943 and #26891 are in reference to the CfnGlobalTable L1 construct and the taggability of the top level entity. CfnGlobalTable does however allow tagging of each replica independently (I know because I'm already doing this today) but this newly created TableV2 L2 construct is not mapping tags to the CfnGlobalTable replicas underneath which is possible with the minor changes I've proposed above. |
Thanks @mikevec23 for the clarification there. |
Any updates on this? It was "self-assigned" a month ago so I figured it would have been worked on shortly after, but if that's not the case I could easily make these changes myself. |
@mikevec23 this isn't currently being prioritized by our team, but we're always happy to take PRs! I've removed my assignment on this. Please feel free to work on this. |
This change adds the ability to tag GlobalTable replicas created using the TableV2 construct. The top level "tags" will apply tags to the primary table while tags for each replica can be specified in the respective replica definition. Closes #27146. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This change adds the ability to tag GlobalTable replicas created using the TableV2 construct. The top level "tags" will apply tags to the primary table while tags for each replica can be specified in the respective replica definition. Closes #27146. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the feature
I would like to be able to supply tags to the primary and secondary replicas within the TableV2 GlobalTable construct.
Use Case
I need to be able to tag specific replicas in order to allow those replicas to be detected by other applications.
Proposed Solution
Tags already exist on the CfnGlobalTable.ReplicaSpecificationProperty type so we simply need to allow the property to be passed to either the TablePropsV2 (for the primary replica) or ReplicaTableProps (for the secondary replicas). Both of these interfaces extend the TableOptionsV2 interface so I would propose the update be added there. Additionally there are some small changes needed to use the tags when configuring the promary replica and when performing the configureReplicaTable method. All these changes are outlined in the attached screenshot of the proposed diff.
Other Information
No response
Acknowledgements
CDK version used
2.96.0
Environment details (OS name and version, etc.)
Node 20.6.1, Mac
The text was updated successfully, but these errors were encountered: