Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dynamodb): Dynamo TableV2 does not support tagging replicas #27146

Closed
1 of 2 tasks
mikevec23 opened this issue Sep 14, 2023 · 6 comments · Fixed by #27649
Closed
1 of 2 tasks

(dynamodb): Dynamo TableV2 does not support tagging replicas #27146

mikevec23 opened this issue Sep 14, 2023 · 6 comments · Fixed by #27649
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@mikevec23
Copy link
Contributor

Describe the feature

I would like to be able to supply tags to the primary and secondary replicas within the TableV2 GlobalTable construct.

Use Case

I need to be able to tag specific replicas in order to allow those replicas to be detected by other applications.

Proposed Solution

Tags already exist on the CfnGlobalTable.ReplicaSpecificationProperty type so we simply need to allow the property to be passed to either the TablePropsV2 (for the primary replica) or ReplicaTableProps (for the secondary replicas). Both of these interfaces extend the TableOptionsV2 interface so I would propose the update be added there. Additionally there are some small changes needed to use the tags when configuring the promary replica and when performing the configureReplicaTable method. All these changes are outlined in the attached screenshot of the proposed diff.

Proposed Changes

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.96.0

Environment details (OS name and version, etc.)

Node 20.6.1, Mac

@mikevec23 mikevec23 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 14, 2023
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Sep 14, 2023
@khushail khushail added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Sep 14, 2023
@khushail
Copy link
Contributor

khushail commented Sep 14, 2023

Hi @mikevec23 , looks like your request is similar to this one - #14943. However there are open issues with CfnGlobalTable.

However if you feel like its not the same you are asking for, please feel free to share more insights into what is expected.

@khushail khushail added p1 effort/medium Medium work item – several days of effort response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Sep 14, 2023
@mikevec23
Copy link
Contributor Author

@khushail Similar but not the same. Both #14943 and #26891 are in reference to the CfnGlobalTable L1 construct and the taggability of the top level entity.

CfnGlobalTable does however allow tagging of each replica independently (I know because I'm already doing this today) but this newly created TableV2 L2 construct is not mapping tags to the CfnGlobalTable replicas underneath which is possible with the minor changes I've proposed above.

@colifran colifran self-assigned this Sep 15, 2023
@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 15, 2023
@khushail
Copy link
Contributor

Thanks @mikevec23 for the clarification there.

@mikevec23
Copy link
Contributor Author

Any updates on this? It was "self-assigned" a month ago so I figured it would have been worked on shortly after, but if that's not the case I could easily make these changes myself.

@colifran colifran removed their assignment Oct 19, 2023
@colifran
Copy link
Contributor

@mikevec23 this isn't currently being prioritized by our team, but we're always happy to take PRs! I've removed my assignment on this. Please feel free to work on this.

@mergify mergify bot closed this as completed in #27649 Oct 26, 2023
mergify bot pushed a commit that referenced this issue Oct 26, 2023
This change adds the ability to tag GlobalTable replicas created using the TableV2 construct. The top level "tags" will apply tags to the primary table while tags for each replica can be specified in the respective replica definition.

Closes #27146.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mrgrain pushed a commit that referenced this issue Nov 1, 2023
This change adds the ability to tag GlobalTable replicas created using the TableV2 construct. The top level "tags" will apply tags to the primary table while tags for each replica can be specified in the respective replica definition.

Closes #27146.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants