Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sagemaker: Create L2 construct for Amazon SageMaker #2809

Closed
3 tasks done
mattmcclean opened this issue Jun 10, 2019 · 5 comments · Fixed by #22549 or #22886
Closed
3 tasks done

sagemaker: Create L2 construct for Amazon SageMaker #2809

mattmcclean opened this issue Jun 10, 2019 · 5 comments · Fixed by #22549 or #22886
Labels
@aws-cdk/aws-sagemaker Related to AWS SageMaker effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@mattmcclean
Copy link
Contributor

mattmcclean commented Jun 10, 2019 •
edited by kaizencc
Loading

There is currently only L1 support for Amazon SageMaker. Would be nice to have an L2 construct to support SageMaker notebook instances, models and endpoints.

This is being actively worked on in three phases 🚀:
@mattmcclean mattmcclean changed the title (sagemaker) Create L2 construct for Amazon SageMaker sagemaker: Create L2 construct for Amazon SageMaker Jun 10, 2019
@mattmcclean mattmcclean mentioned this issue Jun 17, 2019
Closed
4 tasks
@NGL321 NGL321 added the needs-triage This issue or PR still needs to be triaged. label Jun 17, 2019
@skinny85 skinny85 added @aws-cdk/aws-sagemaker Related to AWS SageMaker and removed needs-triage This issue or PR still needs to be triaged. labels Sep 23, 2019
@SomayaB SomayaB added in-progress This issue is being actively worked on. feature-request A feature should be added or improved. and removed gap labels Nov 11, 2019
petermeansrock added a commit to petermeansrock/aws-cdk that referenced this issue Feb 4, 2020
@petermeansrock @mmcclean-aws
@jetterdj @foxpro24 @rangoju
feat(sagemaker): add model hosting L2 constructs
c2b8d37 
Based closely on PR aws#2888, this commit introduces the Endpoint L2
construct and the L2 constructs on which it depends, including Model and
EndpointConfig. Departures from PR aws#2888 include:
- EndpointConfig definition moved into its own L2 construct as one
  EndpointConfig resource may be shared by multiple Endpoints.
- An Endpoint-specific IEndpointProductionVariant interface was added to
  support "metric*" and "autoScale*" APIs per endpoint-variant
  combination.
- The Notebook construct was excluded from this new commit to limit
  changes to model hosting use-cases only.
- Feedback on the earlier PR has been incorporated into this new commit.

fixes aws#2809

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Yao <longyao@amazon.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
@petermeansrock petermeansrock mentioned this issue Feb 4, 2020
Closed
@SomayaB SomayaB assigned NetaNir and unassigned skinny85 Feb 4, 2020
@NetaNir NetaNir added review/large effort/large Large work item – several weeks of effort and removed review/large labels Mar 9, 2020
@SomayaB SomayaB assigned njlynch and unassigned NetaNir Aug 20, 2020
@njlynch
Copy link
Contributor

njlynch commented Aug 21, 2020

See #6107 for the most recent PR.

@njlynch njlynch added the p2 label Aug 25, 2020
@ajaykarpur ajaykarpur mentioned this issue Jul 27, 2021
Open
@ajaykarpur ajaykarpur mentioned this issue Nov 8, 2021
Closed
@petermeansrock petermeansrock mentioned this issue Apr 28, 2022
Closed
4 tasks
petermeansrock added a commit to petermeansrock/aws-cdk that referenced this issue Oct 18, 2022
@petermeansrock @mmcclean-aws
@l2yao @jetterdj @foxpro24 @rangoju
feat(sagemaker): add Model L2 construct
5737194 
This is the first of three PRs to complete the implementation of RFC
431:
aws/aws-cdk-rfcs#431

fixes aws#2809

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
@petermeansrock petermeansrock mentioned this issue Oct 18, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #22549 Nov 9, 2022
mergify bot pushed a commit that referenced this issue Nov 9, 2022
@petermeansrock
feat(sagemaker): add Model L2 construct (#22549)
93915f1 
This is the first of three PRs to complete the implementation of RFC 431:
aws/aws-cdk-rfcs#431

fixes #2809

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@petermeansrock
Copy link
Contributor

petermeansrock commented Nov 10, 2022 •
edited
Loading

@kaizencc Even though only the first of three model hosting PRs have been merged, this issue was auto-closed due to (I assume) the presence of fixes #2809 in my first commit.

  1. Will you please reopen this issue so that we can continue tracking L2 deliverables against it (or if you'd prefer issues per L2 construct, could you reframe this one to align against the Model construct and I can create additional issues)?
  2. Assuming you'd like to continue shipping PRs as part of this issue, would it be possible for you to adjust Matt's description to align with the scope of the RFC, including these three deliverables?
    • feat(sagemaker): add Model L2 construct
    • feat(sagemaker): add EndpointConfig L2 construct
    • feat(sagemaker): add Endpoint L2 construct
  3. Should I avoid using fixes #2809 in the next PR?

@kaizencc kaizencc reopened this Nov 10, 2022
@kaizencc
Copy link
Contributor

@petermeansrock done :). Let's just say something like related to #2809 for the second PR and then we can say closes #2809 for the last one. So they'll still get linked to the issue. Thanks for getting the first part in!

petermeansrock added a commit to petermeansrock/aws-cdk that referenced this issue Nov 10, 2022
@petermeansrock @mmcclean-aws
@l2yao @jetterdj @foxpro24 @rangoju
feat(sagemaker): add EndpointConfig L2 construct
8c8a4f9 
This is the second of three PRs to complete the implementation of RFC
431:
aws/aws-cdk-rfcs#431

related to aws#2809

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
@petermeansrock petermeansrock mentioned this issue Nov 10, 2022
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Nov 11, 2022
@petermeansrock @mmcclean-aws
@l2yao @jetterdj @foxpro24 @rangoju
feat(sagemaker): add EndpointConfig L2 construct (#22865)
0e97c15 
This is the second of three PRs to complete the implementation of RFC 431:
aws/aws-cdk-rfcs#431

related to #2809

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

----

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
petermeansrock added a commit to petermeansrock/aws-cdk that referenced this issue Nov 11, 2022
@petermeansrock @mmcclean-aws
@l2yao @jetterdj @foxpro24 @rangoju
feat(sagemaker): add Endpoint L2 construct
a139468 
This is the third and final PR to complete the implementation of RFC
431:
aws/aws-cdk-rfcs#431

closes aws#2809

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
@petermeansrock petermeansrock mentioned this issue Nov 11, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #22886 Nov 25, 2022
mergify bot pushed a commit that referenced this issue Nov 25, 2022
@petermeansrock @mmcclean-aws
@l2yao @jetterdj @foxpro24 @rangoju
feat(sagemaker): add Endpoint L2 construct (#22886)
bf7586b 
This is the third and final PR to complete the implementation of RFC 431:
aws/aws-cdk-rfcs#431

closes #2809

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

----

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-sagemaker Related to AWS SageMaker effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
8 participants
@skinny85 @mattmcclean @petermeansrock @njlynch @NGL321 @NetaNir @SomayaB @kaizencc