-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sagemaker): add model hosting L2 constructs #6107
Conversation
Based closely on PR aws#2888, this commit introduces the Endpoint L2 construct and the L2 constructs on which it depends, including Model and EndpointConfig. Departures from PR aws#2888 include: - EndpointConfig definition moved into its own L2 construct as one EndpointConfig resource may be shared by multiple Endpoints. - An Endpoint-specific IEndpointProductionVariant interface was added to support "metric*" and "autoScale*" APIs per endpoint-variant combination. - The Notebook construct was excluded from this new commit to limit changes to model hosting use-cases only. - Feedback on the earlier PR has been incorporated into this new commit. fixes aws#2809 Co-authored-by: Matt McClean <mmcclean@amazon.com> Co-authored-by: Yao <longyao@amazon.com> Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com> Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com> Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hi @petermeansrock! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
After merging master into my fork, it looks like the AWS CodeBuild request failed due to an intermittent issue (log link):
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
924c117
to
ebfd5f2
Compare
This PR has unresolved merge conflicts and has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
As an FYI for subscribers, I'm in the process of merging the latest upstream changes into my fork and will create a new PR in the next day or two per the guidance received above. This original PR was never abandoned; I've simply been waiting for feedback from the CDK folks. Hopefully with a new PR, I can get better traction. |
I've created the new PR #20113 to replace this one. |
Based closely on PR #2888, this commit introduces the Endpoint L2
construct and the L2 constructs on which it depends, including Model and
EndpointConfig. Departures from PR #2888 include:
EndpointConfig resource may be shared by multiple Endpoints.
support "metric*" and "autoScale*" APIs per endpoint-variant
combination.
changes to model hosting use-cases only.
Fixes #2809
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license