Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticloadbalancingv2: support ALB attributes #29585

Closed
1 of 2 tasks
badmintoncryer opened this issue Mar 23, 2024 · 2 comments · Fixed by #29586 or rwlxxvii/containers#124 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Closed
1 of 2 tasks

elasticloadbalancingv2: support ALB attributes #29585

badmintoncryer opened this issue Mar 23, 2024 · 2 comments · Fixed by #29586 or rwlxxvii/containers#124 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

badmintoncryer commented Mar 23, 2024 •
edited
Loading

Describe the feature

CDK supports configuring some ALB attributes.

  • routing.http.preserve_host_header.enabled
  • routing.http.x_amzn_tls_version_and_cipher_suite.enabled
  • routing.http.xff_client_port.enabled
  • routing.http.xff_header_processing.mode
  • waf.fail_open.enabled

Use Case

We want to configure these attributes from CDK.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.132.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 23, 2024
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Mar 23, 2024
@badmintoncryer badmintoncryer mentioned this issue Mar 23, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Mar 25, 2024
Closed
@tim-finnigan tim-finnigan self-assigned this Mar 25, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 25, 2024
@tim-finnigan
Copy link

Thank you for the feature request and creating the PR!

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 25, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 25, 2024
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
@mergify mergify bot closed this as completed in #29586 Apr 8, 2024
mergify bot pushed a commit that referenced this issue Apr 8, 2024
@badmintoncryer
feat(elasticloadbalancingv2): application load balancer attributes (#…
067c4a5 
…29586)

### Issue # (if applicable)

Closes #29585.

### Reason for this change

ALB supports some attributes that is not configurable from CDK
- `routing.http.preserve_host_header.enabled`
- `routing.http.x_amzn_tls_version_and_cipher_suite.enabled`
- `routing.http.xff_client_port.enabled`
- `routing.http.xff_header_processing.mode`
- `waf.fail_open.enabled`

### Description of changes

Added some props to `ApplicationLoadBalancerProps`.
- `preserveHostHeader`
- `xAmznTlsVersionAndCipherSuiteHeaders`
- `preserveXffClientPort`
- `xffHeaderProcessingMode`
- `wafFailOpen`

### Description of how you validated changes

Added both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced May 23, 2024
Open
Open
@rwlxxvii rwlxxvii mentioned this issue May 27, 2024
Merged
@NOUIY NOUIY mentioned this issue May 30, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this issue Jun 13, 2024
Open
This was referenced Jun 14, 2024
Open
Open
@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@badmintoncryer @tim-finnigan