feat(elasticloadbalancingv2): application load balancer attributes #29586

badmintoncryer · 2024-03-23T02:22:21Z

Issue # (if applicable)

Closes #29585.

Reason for this change

ALB supports some attributes that is not configurable from CDK

routing.http.preserve_host_header.enabled
routing.http.x_amzn_tls_version_and_cipher_suite.enabled
routing.http.xff_client_port.enabled
routing.http.xff_header_processing.mode
waf.fail_open.enabled

Description of changes

Added some props to ApplicationLoadBalancerProps.

preserveHostHeader
xAmznTlsVersionAndCipherSuiteHeaders
preserveXffClientPort
xffHeaderProcessingMode
wafFailOpen

Description of how you validated changes

Added both unit and integ tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

msambol · 2024-03-23T04:27:24Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts

@@ -65,6 +65,66 @@ export interface ApplicationLoadBalancerProps extends BaseLoadBalancerProps {
   * @default - Duration.seconds(3600)
   */
  readonly clientKeepAlive?: Duration;
+
+  /**
+   * Indicates whether the Application Load Balancer should preserve the Host header in the HTTP request and send it to the target without any change.


nit: can you shorten these descriptions and put them on newlines?

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

msambol · 2024-03-29T23:13:31Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts

+  /**
+   * Application Load Balancer removes the X-Forwarded-For header in the HTTP request before it sends it to targets.
+   */
+  REMOVE = 'remove',


nit: can you shorten these docs and move to multiple lines?

msambol · 2024-03-29T23:17:06Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts

+   *
+   * @default false
+   */
+  readonly xAmznTlsVersionAndCipherSuiteHeaders?: boolean;


can you add @see values with links to AWS docs?

@badmintoncryer Since the urls are the same, I think it'd make more sense to add the @see one time under Properties for defining an Application Load Balancer ?

@msambol I was unable to retrieve links for each attribute and ended up entering the same URL...
I made the revisions just as you suggested!

msambol · 2024-03-29T23:17:29Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts

+   *
+   * @default false
+   */
+  readonly preserveXffClientPort?: boolean;


likewise for this and below, can you add @see ?

badmintoncryer · 2024-03-31T23:24:34Z

@msambol Thank you for your review! I have updated comments.

msambol · 2024-04-01T02:57:30Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/README.md

-  denyAllIgwTraffic: false
+  denyAllIgwTraffic: false,
+
+  // Whether to preserve Host header in the request to the target


nit: lowercase host

msambol · 2024-04-01T02:57:43Z

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts

@@ -68,6 +70,74 @@ export interface ApplicationLoadBalancerProps extends BaseLoadBalancerProps {
   * @default - Duration.seconds(3600)
   */
  readonly clientKeepAlive?: Duration;
+
+  /**
+   * Indicates whether the Application Load Balancer should preserve the Host header in the HTTP request


nit: host

msambol

Two small nits. Looks great 👍🏼

badmintoncryer · 2024-04-01T03:01:22Z

@msambol Thank you very much!

GavinZZ

LGTM, thank you both for reviewing the PR and working on the PR!

mergify · 2024-04-08T22:03:48Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-04-08T22:07:36Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-04-08T22:56:18Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: ca94a94
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-04-08T22:56:43Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

badmintoncryer added 3 commits March 23, 2024 11:06

feat: add ALB attributes

df8fc8b

test: add unit test

86cfa8f

test: update integ test

9f869dd

aws-cdk-automation requested a review from a team March 23, 2024 02:22

github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK feature-request A feature should be added or improved. p2 labels Mar 23, 2024

aws-cdk-automation previously requested changes Mar 23, 2024

View reviewed changes

badmintoncryer force-pushed the albAttributes branch from eba9c25 to 9f869dd Compare March 23, 2024 03:22

msambol reviewed Mar 23, 2024

View reviewed changes

badmintoncryer added 2 commits March 25, 2024 13:02

chore: update description

630752e

docs: update readme

eed2a9c

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 25, 2024

github-actions bot mentioned this pull request Mar 25, 2024

Weekly PR metrics report #29602

Closed

Merge branch 'main' into albAttributes

02303be

msambol reviewed Mar 29, 2024

View reviewed changes

chore: update comments

2ed74bc

Merge branch 'main' into albAttributes

4b75c5d

github-actions bot mentioned this pull request Apr 1, 2024

Monthly PR metrics report #29668

Closed

chore: update comments

b0c440c

msambol reviewed Apr 1, 2024

View reviewed changes

msambol approved these changes Apr 1, 2024

View reviewed changes

badmintoncryer added 2 commits April 1, 2024 11:59

chore: update comments

d8462c7

chore: update comments

518e58c

msambol approved these changes Apr 1, 2024

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 1, 2024

GavinZZ approved these changes Apr 8, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 8, 2024

Merge branch 'main' into albAttributes

ca94a94

mergify bot merged commit 067c4a5 into aws:main Apr 8, 2024
9 checks passed

badmintoncryer deleted the albAttributes branch April 9, 2024 17:07

This was referenced May 23, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#98

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#99

Open

rwlxxvii mentioned this pull request May 27, 2024

[Snyk] Upgrade aws-cdk-lib from 2.136.1 to 2.140.0 rwlxxvii/containers#124

Merged

NOUIY mentioned this pull request May 30, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#101

Open

NOUIY mentioned this pull request Jun 7, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#102

Open

niravparikh05 mentioned this pull request Jun 13, 2024

[Snyk] Upgrade aws-cdk from 2.65.0 to 2.142.1 paralus/eks-blueprints-addon#3

Open

This was referenced Jun 14, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#103

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#104

Open

aws locked as resolved and limited conversation to collaborators Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(elasticloadbalancingv2): application load balancer attributes #29586

feat(elasticloadbalancingv2): application load balancer attributes #29586

badmintoncryer commented Mar 23, 2024

aws-cdk-automation left a comment

msambol Mar 23, 2024

msambol Mar 29, 2024

msambol Mar 29, 2024

msambol Apr 1, 2024

badmintoncryer Apr 1, 2024

msambol Mar 29, 2024

badmintoncryer commented Mar 31, 2024

msambol Apr 1, 2024

msambol Apr 1, 2024

msambol left a comment

badmintoncryer commented Apr 1, 2024

GavinZZ left a comment •

edited

Loading

mergify bot commented Apr 8, 2024

mergify bot commented Apr 8, 2024

aws-cdk-automation commented Apr 8, 2024

mergify bot commented Apr 8, 2024

feat(elasticloadbalancingv2): application load balancer attributes #29586

feat(elasticloadbalancingv2): application load balancer attributes #29586

Conversation

badmintoncryer commented Mar 23, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

badmintoncryer commented Mar 31, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msambol left a comment

Choose a reason for hiding this comment

badmintoncryer commented Apr 1, 2024

GavinZZ left a comment • edited Loading

Choose a reason for hiding this comment

mergify bot commented Apr 8, 2024

mergify bot commented Apr 8, 2024

aws-cdk-automation commented Apr 8, 2024

AWS CodeBuild CI Report

mergify bot commented Apr 8, 2024

GavinZZ left a comment •

edited

Loading