Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docdb): copyTagsToSnapshot is missing in the DatabaseCluster Construct #30090

Closed
1 of 2 tasks
Assignees
Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB feature-request A feature should be added or improved.

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented May 7, 2024

Describe the feature

In the DatabaseCluster Construct, copyTagsToSnapshot is missing.

Use Case

Use this when you want to copy tags to snapshots.

Proposed Solution

Add copyTagsToSnapshot to the DatabaseCluster Construct.

const cluster = new docdb.DatabaseCluster(this, 'Database', {
  masterUser: {
    username: 'myuser', // NOTE: 'admin' is reserved by DocumentDB
    excludeCharacters: '\"@/:', // optional, defaults to the set "\"@/" and is also used for eventually created rotations
    secretName: '/myapp/mydocdb/masteruser', // optional, if you prefer to specify the secret name
  },
  instanceType: ec2.InstanceType.of(ec2.InstanceClass.MEMORY5, ec2.InstanceSize.LARGE),
  vpc,
  copyTagsToSnapshot: true, // Add
});

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.140.0

Environment details (OS name and version, etc.)

MacOS

@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 7, 2024
@github-actions github-actions bot added the @aws-cdk/aws-docdb Related to Amazon DocumentDB label May 7, 2024
@ashishdhingra
Copy link
Contributor

Refer AWS::DocDB::DBCluster, CopyTagsToSnapshot is a supported property.

@mazyu36 Looks like you linked this issue to a PR for experimental aws-neptune-alpha construct. Please check if you intended to create a separate PR for aws-cdk-lib.aws_docdb DatabaseCluster construct.

Thanks,
Ashish

@ashishdhingra ashishdhingra added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels May 7, 2024
@ashishdhingra ashishdhingra self-assigned this May 7, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented May 7, 2024

@ashishdhingra
Thanks for your confirmation.
I mistakenly linked a neptune PR, so I've now removed.

For the different module, I plan to create a separate pull request for the docdb changes, distinct from the one for neptune. Apologies for the confusion.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label May 7, 2024
@mergify mergify bot closed this as completed in #30120 May 12, 2024
mergify bot pushed a commit that referenced this issue May 12, 2024
…onstruct (#30120)

### Issue # (if applicable)

Closes #30090 

### Reason for this change
As described in the issue.



### Description of changes
Add copyTagsToSnapshot property to the DatabaseCluster Construct.



### Description of how you validated changes
Add both unit tests and integ tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.