Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-apprunner-alpha): missing apprunner runtime Python_311 #30146

Closed
hiselitelordship opened this issue May 10, 2024 · 2 comments · Fixed by #30149
Closed

(aws-apprunner-alpha): missing apprunner runtime Python_311 #30146

hiselitelordship opened this issue May 10, 2024 · 2 comments · Fixed by #30149
Labels
@aws-cdk/aws-apprunner Related to the apprunner package bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@hiselitelordship
Copy link

Describe the bug

Apprunner supports two Python Runtimes: 3 and 311 as documented here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apprunner-service-codeconfigurationvalues.html

PYTHON_311 is missing from https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-apprunner-alpha/lib/service.ts#L210

Expected Behavior

It is expected that the CDK should make all supported runtimes available.

Current Behavior

It only supports Python_3 (this translates to the extremely old Python 3.8)

Reproduction Steps

apprunner_alpha.Service(
self,
"My Web Site",
instance_role=web_instance_role,
source=apprunner_alpha.Source.from_git_hub(
repository_url="",
branch="main",
configuration_source=apprunner_alpha.ConfigurationSourceType.API,
code_configuration_values=apprunner_alpha.CodeConfigurationValues(
runtime=apprunner_alpha.Runtime.PYTHON_3,
port="5000",
start_command="",
build_command="",
environment_variables={},
),
connection=apprunner_alpha.GitHubConnection.from_connection_arn(
web_github_arn
),
),
)

Possible Solution

/**

  • Python 3.11
    */
    public static readonly PYTHON_311 = Runtime.of('PYTHON_311')

Additional Information/Context

No response

CDK CLI Version

2.140.0

Framework Version

No response

Node.js Version

v20.9.0

OS

Ubuntu

Language

Python

Language Version

Python 3.11

Other information

No response
@hiselitelordship hiselitelordship added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 10, 2024
@github-actions github-actions bot added the @aws-cdk/aws-apprunner Related to the apprunner package label May 10, 2024
@ashishdhingra ashishdhingra self-assigned this May 10, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 10, 2024
@ashishdhingra
Copy link
Contributor

Appears to be a valid request for experimental aws-apprunner-alpha package. @hiselitelordship Feel free to contribute PR which could be reviewed by the team.

@ashishdhingra ashishdhingra added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 10, 2024
@ashishdhingra ashishdhingra removed their assignment May 10, 2024
@mellevanderlinde mellevanderlinde mentioned this issue May 10, 2024
Merged
This was referenced May 13, 2024
Closed
Closed
@github-actions github-actions bot mentioned this issue Jun 1, 2024
Closed
@mergify mergify bot closed this as completed in #30149 Jul 31, 2024
mergify bot pushed a commit that referenced this issue Jul 31, 2024
@mellevanderlinde
chore(apprunner-alpha): add runtimes PYTHON_311 and NODEJS_18 (#30149)
ad3a25d 
### Issue # (if applicable)

Closes #30146.

### Reason for this change

Runtimes Python 3.11 and NodeJS 18 were missing.

### Description of changes

Runtimes Python 3.11 and NodeJS 18 were added.

### Description of how you validated changes

No tests were added, as it seems not required for this type of change.

### Checklist
- [*] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-apprunner Related to the apprunner package bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(apprunner-alpha): add runtimes PYTHON_311 and NODEJS_18 mellevanderlinde/aws-cdk
2 participants
@hiselitelordship @ashishdhingra