Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apprunner-alpha): add runtimes PYTHON_311 and NODEJS_18 #30149

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

mellevanderlinde
Copy link
Contributor

@mellevanderlinde mellevanderlinde commented May 10, 2024

Issue # (if applicable)

Closes #30146.

Reason for this change

Runtimes Python 3.11 and NodeJS 18 were missing.

Description of changes

Runtimes Python 3.11 and NodeJS 18 were added.

Description of how you validated changes

No tests were added, as it seems not required for this type of change.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels May 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 10, 2024 21:20
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mellevanderlinde mellevanderlinde changed the title feat(apprunner-alpha): add runtimes PYTHON_311 and NODEJS_18 chore(apprunner-alpha): add runtimes PYTHON_311 and NODEJS_18 May 13, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 13, 2024 09:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 13, 2024
@TheRealAmazonKendra TheRealAmazonKendra dismissed their stale review June 6, 2024 17:47

other PR with this change came first

@mellevanderlinde
Copy link
Contributor Author

@TheRealAmazonKendra It seems like the other (very similar) PR has been closed (i.e., not merged) (see #30156). Does that by any chance mean that this PR can move forward?

Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

Copy link
Contributor

mergify bot commented Jul 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Jul 31, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 31, 2024
Copy link
Contributor

mergify bot commented Jul 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1e96702
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ad3a25d into aws:main Jul 31, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Jul 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
@mellevanderlinde mellevanderlinde deleted the apprunner_runtimes branch August 1, 2024 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-apprunner-alpha): missing apprunner runtime Python_311
3 participants