-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: include PYTHON_311 runtime in aws-apprunner-alpha #30156
chore: include PYTHON_311 runtime in aws-apprunner-alpha #30156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
@Mergifyio update |
Pull request has been modified.
☑️ Nothing to do
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Not sure what happened here with mergify but there was a PR submitted just prior to this one with the same addition. We prioritize the earlier change in situations like this so I'll be closing this one in favor of #30149 |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Apprunner supports two Python Runtimes: 3 and 311 as documented here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apprunner-service-codeconfigurationvalues.html
Python 3.11 not present in aws-apprunner-alpha runtime values.
Description of changes
Add PYTHON_311 to available list of runtimes:
public static readonly PYTHON_311 = Runtime.of('PYTHON_311')
Description of how you validated changes
No unit tests. This is a direct copy of the PYTHON_3 readonly property. Confirmed that there was nothing to do in the adjacent
public static of
function.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license