Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include PYTHON_311 runtime in aws-apprunner-alpha #30156

Conversation

hiselitelordship
Copy link

Reason for this change

Apprunner supports two Python Runtimes: 3 and 311 as documented here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apprunner-service-codeconfigurationvalues.html

Python 3.11 not present in aws-apprunner-alpha runtime values.

Description of changes

Add PYTHON_311 to available list of runtimes:
public static readonly PYTHON_311 = Runtime.of('PYTHON_311')

Description of how you validated changes

No unit tests. This is a direct copy of the PYTHON_3 readonly property. Confirmed that there was nothing to do in the adjacent public static of function.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 11, 2024 08:08
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels May 11, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@hiselitelordship hiselitelordship changed the title Add support for PYTHON_311 runtime in aws-apprunner-alpha fix: Add support for PYTHON_311 runtime in aws-apprunner-alpha May 11, 2024
@hiselitelordship hiselitelordship changed the title fix: Add support for PYTHON_311 runtime in aws-apprunner-alpha fix: add support for PYTHON_311 runtime in aws-apprunner-alpha May 11, 2024
@hiselitelordship hiselitelordship changed the title fix: add support for PYTHON_311 runtime in aws-apprunner-alpha chore: include PYTHON_311 runtime in aws-apprunner-alpha May 11, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 11, 2024 08:34

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 11, 2024
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

mergify bot commented Jun 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 6, 2024
Copy link
Contributor

mergify bot commented Jun 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jul 5, 2024
@paulhcsun paulhcsun reopened this Jul 24, 2024
@paulhcsun
Copy link
Contributor

@Mergifyio update

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review July 24, 2024 21:21

Pull request has been modified.

Copy link
Contributor

mergify bot commented Jul 24, 2024

update

☑️ Nothing to do

  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9b52acd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jul 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@TheRealAmazonKendra
Copy link
Contributor

Not sure what happened here with mergify but there was a PR submitted just prior to this one with the same addition. We prioritize the earlier change in situations like this so I'll be closing this one in favor of #30149

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants