Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: everywhere we use a waiter we have to adjust the message to take waiter errors into account #32481

Closed
2 tasks
rix0rrr opened this issue Dec 11, 2024 · 2 comments · Fixed by #33035
Closed
2 tasks

cli: everywhere we use a waiter we have to adjust the message to take waiter errors into account #32481

rix0rrr opened this issue Dec 11, 2024 · 2 comments · Fixed by #33035
Assignees
@otaviomacedo
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Dec 11, 2024

Describe the feature

This PR smithy-lang/smithy-typescript#1467 changed the information that is contained in an error thrown from a waiter.

We must include the additional error detail in the message we print to the screen.

Use Case

If we do not, permissions errors are invisible.

While we're at it, see also: #32237

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

Environment details (OS name and version, etc.)
@rix0rrr rix0rrr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 11, 2024
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Dec 11, 2024
@rix0rrr rix0rrr mentioned this issue Dec 11, 2024
Closed
1 task
@ashishdhingra ashishdhingra self-assigned this Dec 11, 2024
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 11, 2024
@ashishdhingra
Copy link
Contributor

Opened by CDK team. Marking it as p2.

@ashishdhingra ashishdhingra added effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 11, 2024
@ashishdhingra ashishdhingra removed their assignment Dec 12, 2024
This was referenced Jan 1, 2025
Open
Open
Open
@otaviomacedo otaviomacedo self-assigned this Jan 8, 2025
@jiayiwang7 jiayiwang7 added p1 bug This issue is a bug. and removed p2 labels Jan 8, 2025
@otaviomacedo otaviomacedo mentioned this issue Jan 21, 2025
Merged
otaviomacedo added a commit that referenced this issue Jan 22, 2025
@otaviomacedo
feat(cli): show all information from waiter errors (#33035)
b512a72 
Waiter errors now have an additional piece of information: the responses
that were observed during the polling, and their counts.

Relay this information to the user in the error message.

Closes #32481.

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@otaviomacedo otaviomacedo

Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): show all information from waiter errors aws/aws-cdk
4 participants
@otaviomacedo @rix0rrr @jiayiwang7 @ashishdhingra