-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update & test all AWS-owned CodePipeline Actions to pass their backing resource #3389
Closed
5 of 7 tasks
Labels
@aws-cdk/aws-codepipeline
Related to AWS CodePipeline
effort/large
Large work item – several weeks of effort
Comments
skinny85
added a commit
to skinny85/aws-cdk
that referenced
this issue
Sep 28, 2019
…ions Previously, we only supported cross-environment deployments for CodeBuild and CloudFormation CodePipeline actions. This change adds this capability to all remaining AWS-owned actions. Fixes aws#3389
skinny85
added a commit
to skinny85/aws-cdk
that referenced
this issue
Sep 30, 2019
…ions Previously, we only supported cross-environment deployments for CodeBuild and CloudFormation CodePipeline actions. This change adds this capability to all remaining AWS-owned actions. Fixes aws#3389
skinny85
added a commit
to skinny85/aws-cdk
that referenced
this issue
Oct 4, 2019
…ions Previously, we only supported cross-environment deployments for CodeBuild and CloudFormation CodePipeline actions. This change adds this capability to all remaining AWS-owned actions. Fixes aws#3389
skinny85
added a commit
to skinny85/aws-cdk
that referenced
this issue
Oct 4, 2019
…ions Previously, we only supported cross-environment deployments for CodeBuild and CloudFormation CodePipeline actions. This change adds this capability to all remaining AWS-owned actions. Fixes aws#3389
skinny85
added a commit
to skinny85/aws-cdk
that referenced
this issue
Oct 5, 2019
…ions Previously, we only supported cross-environment deployments for CodeBuild and CloudFormation CodePipeline actions. This change adds this capability to all remaining AWS-owned actions. Fixes aws#3389
skinny85
added a commit
to skinny85/aws-cdk
that referenced
this issue
Oct 7, 2019
…ions Previously, we only supported cross-environment deployments for CodeBuild and CloudFormation CodePipeline actions. This change adds this capability to all remaining AWS-owned actions. Fixes aws#3389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-codepipeline
Related to AWS CodePipeline
effort/large
Large work item – several weeks of effort
Actions that have the default
'AWS'
owner (other than the CloudFormation Actions, which work differently) have to pass the resource they are backed by up to the CodePipeline construct in order for the cross-region and cross-account functionality to work correctly.Each of these needs a small code change (modifying the call to
super
to pass theresource
property), and, more importantly, a manual test that verifies a cross-environment Pipeline including them works like expected. This test part is very important, as it's quite common to run into many subtle issues that are difficult to predict without actually using the Actions in a cross-environment manner (like the need to create inner resources withPhysicalName.GENERATE_IF_NEEDED
, or the fact that source Actions require cross-account CloudWatch Events).(CodeBuild had been already updated & tested as the first, "beta" cross-account Action)
The text was updated successfully, but these errors were encountered: