-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codepipeline): support cross-environment deployments for all actions #4276
Conversation
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
There is an interesting aspect to this PR. The CodePipeline API has a very short limit on the ArtifactStore.EncryptionKey.Id property (just 100 characters). That is problematic when using Alias ARNs in there, as an Alias can have just its name be up to 256 characters long. I've opened an issue about it to the CodePipeline team, and worked around this problem in this PR (here). Depending on what we think is better, we can wait until the issue is fixed, and remove that workaround, or merge this as-is, and later change the generated Alias name. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
packages/@aws-cdk/aws-codepipeline-actions/lib/codecommit/source-action.ts
Show resolved
Hide resolved
83bb4ed
to
89be270
Compare
Rebased & and added a local cache of account to |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
89be270
to
1be7e63
Compare
Moved the Alias hack to the CodePipeline module, according to Elad's comment, and rebased. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
1be7e63
to
e164f2c
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
e164f2c
to
e151374
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…ions Previously, we only supported cross-environment deployments for CodeBuild and CloudFormation CodePipeline actions. This change adds this capability to all remaining AWS-owned actions. Fixes aws#3389
e151374
to
04252d7
Compare
Changed |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Previously, we only supported cross-environment deployments for CodeBuild
and CloudFormation CodePipeline actions.
This change adds this capability to all remaining AWS-owned actions.
Fixes #3389
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license