Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codepipeline): support cross-environment deployments for all actions #4276

Merged
merged 2 commits into from
Oct 7, 2019

Conversation

skinny85
Copy link
Contributor

Previously, we only supported cross-environment deployments for CodeBuild
and CloudFormation CodePipeline actions.
This change adds this capability to all remaining AWS-owned actions.

Fixes #3389


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from eladb September 28, 2019 01:25
@skinny85 skinny85 requested a review from rix0rrr as a code owner September 28, 2019 01:25
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@skinny85
Copy link
Contributor Author

There is an interesting aspect to this PR. The CodePipeline API has a very short limit on the ArtifactStore.EncryptionKey.Id property (just 100 characters). That is problematic when using Alias ARNs in there, as an Alias can have just its name be up to 256 characters long. I've opened an issue about it to the CodePipeline team, and worked around this problem in this PR (here). Depending on what we think is better, we can wait until the issue is fixed, and remove that workaround, or merge this as-is, and later change the generated Alias name.

@skinny85 skinny85 added the pr/do-not-merge This PR should not be merged at this time. label Sep 28, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 force-pushed the feat/all-cross-account-actions branch from 83bb4ed to 89be270 Compare September 30, 2019 22:25
@skinny85
Copy link
Contributor Author

Rebased & and added a local cache of account to Pipeline.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 force-pushed the feat/all-cross-account-actions branch from 89be270 to 1be7e63 Compare October 4, 2019 01:01
@skinny85
Copy link
Contributor Author

skinny85 commented Oct 4, 2019

Moved the Alias hack to the CodePipeline module, according to Elad's comment, and rebased.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 force-pushed the feat/all-cross-account-actions branch from 1be7e63 to e164f2c Compare October 4, 2019 20:32
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 force-pushed the feat/all-cross-account-actions branch from e164f2c to e151374 Compare October 5, 2019 00:28
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…ions

Previously, we only supported cross-environment deployments for CodeBuild
and CloudFormation CodePipeline actions.
This change adds this capability to all remaining AWS-owned actions.

Fixes aws#3389
@skinny85 skinny85 force-pushed the feat/all-cross-account-actions branch from e151374 to 04252d7 Compare October 7, 2019 16:57
@skinny85
Copy link
Contributor Author

skinny85 commented Oct 7, 2019

Changed Rule like we talked about. I also needed to override the validate method in the inner class, but that makes sense when you think about it (otherwise, all validation errors for that rule would be duplicated).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 removed the pr/do-not-merge This PR should not be merged at this time. label Oct 7, 2019
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1eebf92 into aws:master Oct 7, 2019
@skinny85 skinny85 deleted the feat/all-cross-account-actions branch October 7, 2019 21:57
@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update & test all AWS-owned CodePipeline Actions to pass their backing resource
5 participants