Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PassProp Should accept parameters just like StateProp. #3453

Closed
1 task
nikamipara opened this issue Jul 27, 2019 · 4 comments · Fixed by #4815
Closed
1 task

PassProp Should accept parameters just like StateProp. #3453

nikamipara opened this issue Jul 27, 2019 · 4 comments · Fixed by #4815
Assignees
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@nikamipara
Copy link

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

  • I'm submitting a ...

    • 🪲 bug report
  • What is the current behavior?
    If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce

Pass State Props currently does not support adding parameters :

  • What is the expected behavior (or behavior of feature suggested)?

It should accept parameters just like State.

readonly parameters?: { [name: string]: any };

  • What is the motivation / use case for changing the behavior or adding this feature?

parameters gives more freedom to mainipulate json input.

https://docs.aws.amazon.com/step-functions/latest/dg/input-output-inputpath-params.html

  • Please tell us about your environment:

    • CDK CLI Version: xx.xx.xx
    • Module Version: xx.xx.xx
    • OS: [all | Windows 10 | OSX Mojave | Ubuntu | etc... ]
    • Language: [all | TypeScript | Java | Python ]
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

@nikamipara nikamipara added the needs-triage This issue or PR still needs to be triaged. label Jul 27, 2019
@eladb eladb added feature-request A feature should be added or improved. @aws-cdk/aws-stepfunctions Related to AWS StepFunctions labels Aug 13, 2019
@rbs392
Copy link

rbs392 commented Aug 26, 2019

Hi @rix0rrr
Any updates on when this will be implemented??

@rix0rrr rix0rrr removed the needs-triage This issue or PR still needs to be triaged. label Aug 28, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 28, 2019

We are not focusing on StepFunctions right now. Would be happy to accept PRs though.

@alukach
Copy link
Contributor

alukach commented Sep 26, 2019

PassProp Should accept parameters just like StateProp.

I believe that TaskProps should also accept parameters.

@sinistral
Copy link

This appears to be related to #1480, which includes a patch that might be adapted for use with Pass.

alukach added a commit to alukach/aws-cdk that referenced this issue Nov 1, 2019
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Nov 1, 2019
@mergify mergify bot closed this as completed in #4815 Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
7 participants