Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions): Task and Pass also support parameters #4815

Merged

Conversation

alukach
Copy link
Contributor

@alukach alukach commented Nov 1, 2019


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

I think this should address #3453, however it's such a simple change that I'm worried that I may be missing something larger. I am not entirely familiar with CDK's inner-workings.

fixes #3453

This supercedes #4247

@alukach alukach requested a review from eladb as a code owner November 1, 2019 20:14
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@alukach
Copy link
Contributor Author

alukach commented Nov 1, 2019

From #4247:

This allows passing of the field. Does it get rendered? Please add a test to prove that it does.

@rix0rrr I believe this is now addressed.

@alukach alukach changed the title Add parameters to TaskProp, PassProp [fixes #3453] fix: Add parameters to TaskProp, PassProp [fixes #3453] Nov 1, 2019
@alukach alukach changed the title fix: Add parameters to TaskProp, PassProp [fixes #3453] fix(stepfunctions): Add parameters to TaskProp, PassProp [fixes #3453] Nov 1, 2019
@rix0rrr rix0rrr changed the title fix(stepfunctions): Add parameters to TaskProp, PassProp [fixes #3453] fix(stepfunctions): Task and Pass also support parameters Nov 4, 2019
@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@gzhennin
Copy link

I couldn't locate the interface of this in CDK Java. Please add that!

@alukach alukach deleted the support-parameters-in-taskprops-and-passprops branch February 8, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PassProp Should accept parameters just like StateProp.
4 participants