Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom resource implementation for Fargate event target #3930

Closed
1 of 2 tasks
jogold opened this issue Sep 4, 2019 · 0 comments · Fixed by #3952
Closed
1 of 2 tasks

Remove custom resource implementation for Fargate event target #3930

jogold opened this issue Sep 4, 2019 · 0 comments · Fixed by #3952
Assignees
@rix0rrr
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-events Related to CloudWatch Events feature-request A feature should be added or improved.

Comments

@jogold
Copy link
Contributor

jogold commented Sep 4, 2019

🚀 Feature Request

General Information

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

Description

The EcsTask target in @aws-cdk/aws-events currently uses a custom resource for Fargate/awsvpc tasks due to lack of CF support (see #2707).

CF just released support for Group, LaunchType, NetworkConfiguration and PlatformVersion in AWS::Events::Rule > Target > EcsParameters (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-events-rule-ecsparameters.html).

image

The custom resource implementation should be removed in favor of a CF only solution.

Proposed Solution

Remove the custom resource after CF resource specification has been updated.

Other information

See also aws-cloudformation/cloudformation-coverage-roadmap#23
@jogold jogold added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 4, 2019
@SomayaB SomayaB added @aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-events Related to CloudWatch Events labels Sep 4, 2019
@jogold jogold changed the title Remove custom resource implemenation for Fargate event target Remove custom resource implementation for Fargate event target Sep 5, 2019
jogold added a commit to jogold/aws-cdk that referenced this issue Sep 5, 2019
@jogold
chore(events): remove custom resource for fargate event target
f0a9e46 
The latest CloudFormation specification adds `LaunchType` and `NetworkConfiguration` properties to
the `EcsParameters` property. A custom resource to set those values is no longer needed.

Closes aws#3930
@jogold jogold mentioned this issue Sep 5, 2019
Merged
@rix0rrr rix0rrr removed the needs-triage This issue or PR still needs to be triaged. label Sep 9, 2019
@mergify mergify bot closed this as completed in #3952 Sep 11, 2019
mergify bot pushed a commit that referenced this issue Sep 11, 2019
@jogold @mergify
fix(events): remove custom resource for fargate event target (#3952)
920f12f 
* chore(events): remove custom resource for fargate event target

The latest CloudFormation specification adds `LaunchType` and `NetworkConfiguration` properties to
the `EcsParameters` property. A custom resource to set those values is no longer needed.

Closes #3930

* fix comma in package.json after fixing merge conflict
@eladb eladb mentioned this issue Jan 28, 2020
Closed
12 tasks
@eladb eladb mentioned this issue Feb 4, 2020
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-events Related to CloudWatch Events feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(events): remove custom resource for fargate event target jogold/aws-cdk
3 participants
@rix0rrr @jogold @SomayaB