Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event-targets): add support for fargate/awsvpc tasks #2707

Merged
merged 3 commits into from
Jun 3, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented May 31, 2019

The target is "enhanced" using an AwsCustomResource calling CloudWatchEvents.putTargets.

Fix wrong reference to container name in containerOverrides (must be name).

BREAKING CHANGE: targets.EcsEc2Task renamed to targets.EcsTask


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Sorry, something went wrong.

The target is "enhanced" using an AwsCustomResource calling `CloudWatchEvents.putTargets`.

Fix wrong reference to container name in `containerOverrides` (must be `name`).

BREAKING CHANGE: `targets.EcsEc2Task` renamed to `targets.EcsTask`
@jogold jogold requested review from SoManyHs and a team as code owners May 31, 2019 15:27
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Looks beautiful.

@SoManyHs @rix0rrr can you please take a look? Looks good to me.

const assignPublicIp = subnetSelection.subnetType === ec2.SubnetType.Private ? 'DISABLED' : 'ENABLED';

new cloudformation.AwsCustomResource(this.taskDefinition, 'PutTargets', {
onUpdate: { // We don't need an onDelete here because the target will be owned by CF anyway
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing to me. Why no onCreate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onCreate defaults to onUpdate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say I have mixed feelings about this implementation... but I guess this is the point of the CDK :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which implementation, AwsCustomResource or this ECS target?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the fact that it is using a custom resource to achieve its goal.

@rix0rrr rix0rrr merged commit 2754dde into aws:master Jun 3, 2019
@jogold jogold deleted the fargate-event-target branch June 13, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants