Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-eks] If add two helm chart only one chart can get be installed #6806

Closed
jluo-bgl opened this issue Mar 19, 2020 · 6 comments · Fixed by #8780
Closed

[aws-eks] If add two helm chart only one chart can get be installed #6806

jluo-bgl opened this issue Mar 19, 2020 · 6 comments · Fixed by #8780
Assignees
@eladb @iliapolo
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. p1
Milestone
[DevPreview] @aws...

Comments

@jluo-bgl
Copy link

jluo-bgl commented Mar 19, 2020 •
edited
Loading

If add two helm chart only one chart can get be installed

Reproduction Steps

Error Log

No error log, after deploy cdk, only one chart in kubectrl deployment list

Environment

  • **CLI Version :1.17
  • **Framework Version:1.28
  • **OS :MacOS
  • **Language :Java

Other

This is 🐛 Bug Report
@jluo-bgl jluo-bgl added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 19, 2020
@SomayaB SomayaB added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Mar 19, 2020
@eladb eladb added the p1 label Mar 20, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label May 19, 2020
@eduardomourar
Copy link
Contributor

This is probably related #7592. And you should be able to resolve by using method addDepencies.

@eladb
Copy link
Contributor

eladb commented Jun 24, 2020

Closing as dup

@eladb eladb closed this as completed Jun 24, 2020
@eladb eladb reopened this Jun 24, 2020
@eladb
Copy link
Contributor

eladb commented Jun 24, 2020

Does this happen for any two Helm charts? If that's the case we can serialize Helm chart updates.

@eladb eladb added this to the EKS Developer Preview milestone Jun 24, 2020
@eladb eladb changed the title If add two helm chart only one chart can get be installed [EKS Bug] If add two helm chart only one chart can get be installed Jun 24, 2020
@eladb eladb removed this from the EKS Developer Preview milestone Jun 24, 2020
@eduardomourar
Copy link
Contributor

I cannot say for previous CDK versions, but with current v1.46.0 I am able to deploy two helm charts in the same stack. Whenever I ran into these issues, I solve it by setting the wait flag to true and adding dependency.

@jluo-bgl
Copy link
Author

I was trying to install "external-dns" and "aws-alb-ingress-controller" together and no luck. I will give the new version an other try. Thanks for looking into this.

@eladb
Copy link
Contributor

eladb commented Jun 29, 2020

I was trying to install "external-dns" and "aws-alb-ingress-controller" together and no luck. I will give the new version an other try. Thanks for looking into this.

Since both charts install the same nginx CRD you won't be able to install them concurrently so make sure to add a dependency between the two charts.

@eladb eladb mentioned this issue Jun 29, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Jun 29, 2020
@SomayaB SomayaB changed the title [EKS Bug] If add two helm chart only one chart can get be installed [EKS] If add two helm chart only one chart can get be installed Jun 29, 2020
@mergify mergify bot closed this as completed in #8780 Jul 1, 2020
mergify bot pushed a commit that referenced this issue Jul 1, 2020
feat(eks): document how to define dependencies for resources and char…
e38b692 
…ts (#8780)

- Added README content describing how to define deps for resources and helm charts.
- Updated integ test to define a k8s namespace and install nginx inside it.

Fixes #7592
Fixes #6806


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iliapolo iliapolo added this to the EKS Dev Preview milestone Aug 10, 2020
@iliapolo iliapolo removed the in-progress This issue is being actively worked on. label Aug 16, 2020
@iliapolo iliapolo changed the title [EKS] If add two helm chart only one chart can get be installed [aws-eks] If add two helm chart only one chart can get be installed Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

@iliapolo iliapolo

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. p1
Projects
None yet
Milestone
[DevPreview] @aws-cdk/aws-eks
Development

Successfully merging a pull request may close this issue.

feat(eks): document how to define dependencies for resources and charts aws/aws-cdk
5 participants
@eladb @iliapolo @jluo-bgl @eduardomourar @SomayaB