Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eks): document how to define dependencies for resources and charts #8780

Merged
merged 12 commits into from
Jul 1, 2020
Merged

feat(eks): document how to define dependencies for resources and charts #8780

merged 12 commits into from
Jul 1, 2020

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jun 29, 2020

  • Added README content describing how to define deps for resources and helm charts.
  • Updated integ test to define a k8s namespace and install nginx inside it.

Fixes #7592
Fixes #6806

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

feat(eks): document how to define dependencies for resources and charts
dcf812c 
- Added README content describing how to define deps for resources and helm charts.
- Updated integ test to define a k8s namespace and install nginx inside it.

Fixes #7592
Fixes #6806
@eladb eladb requested review from a team and iliapolo June 29, 2020 12:16
nija-at
nija-at reviewed Jun 29, 2020
View reviewed changes
packages/@aws-cdk/aws-eks/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-eks/test/integ.eks-cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-eks/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-eks/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-eks/test/integ.eks-cluster.ts Outdated Show resolved Hide resolved
Elad Ben-Israel and others added 3 commits June 29, 2020 20:04
Update packages/@aws-cdk/aws-eks/README.md
8ed9563 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Update packages/@aws-cdk/aws-eks/test/integ.eks-cluster.ts
f2c0d69 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Update packages/@aws-cdk/aws-eks/README.md
d181277 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@eladb eladb requested a review from nija-at June 29, 2020 17:06
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 29, 2020
@mergify
Copy link
Contributor

mergify bot commented Jun 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7f6c4a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e38b692 into master Jul 1, 2020
@mergify mergify bot deleted the benisrae/eks-deps branch July 1, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

@iliapolo iliapolo Awaiting requested review from iliapolo

Assignees

@eladb eladb

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
3 participants
@eladb @aws-cdk-automation @nija-at