Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Token to an interface #79

Closed
eladb opened this issue Jun 11, 2018 · 2 comments
Closed

Convert Token to an interface #79

eladb opened this issue Jun 11, 2018 · 2 comments
Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version.

Comments

@eladb
Copy link
Contributor

eladb commented Jun 11, 2018

There is no reason why Token shouldn't be an interface now that interfaces are supported in jsii
@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 17, 2018

@eladb Ha! ;)

@rix0rrr rix0rrr closed this as completed Sep 17, 2018
@eladb eladb reopened this Jan 8, 2019
@eladb eladb mentioned this issue Jan 8, 2019
Merged
4 tasks
@eladb eladb added pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version. feature-request A feature should be added or improved. labels Jan 10, 2019
@eladb eladb added the @aws-cdk/core Related to core CDK functionality label Mar 4, 2019
@eladb eladb mentioned this issue Mar 14, 2019
Merged
4 tasks
@RomainMuller
Copy link
Contributor

This was done, I feel :)

homakk pushed a commit to homakk/aws-cdk that referenced this issue Dec 1, 2022
@bvtujo
Merge pull request aws#79 from aws/service-connect-cfnspec
c8ca9d4 
Service connect cfnspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RomainMuller @rix0rrr @eladb