feat: cloudformation condition chaining #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 8, 2019 10:17
BREAKING CHANGE: the deprecated `cloudformation.XxxResource` classes have been removed. Use the `CfnXxx` classes instead.
Change `conditionXx` methods to accept an interface `IConditionExpression` instead of concrete class and implement this interface by the `Condition` construct. This enables chaining conditions like so: const cond1, cond2, cond, cond4 = new cdk.Condition(...) Fn.conditionOr(cond1, cond2, Fn.conditionAnd(cond3, cond4)) Fixes #1457
RomainMuller
approved these changes
Jan 8, 2019
rix0rrr
reviewed
Jan 8, 2019
| /** | ||
| * Returns a JSON node that represents this condition expression | ||
| */ | ||
| resolve(): any; |
There was a problem hiding this comment.
Why resolve() and not a more specific fucntion name? If you wanted resolve() you could have accepted a Token, or a ConditionBase
There was a problem hiding this comment.
But I wanted the Condition construct to implement it, so I had to define it as an interface. And I want the recursive resolution behavior of tokens to apply to full expressions, so I just faked it.
We should probably define an IToken with a resolve method so (reopened #79)
rix0rrr
reviewed
Jan 8, 2019
| super({ [type]: value }); | ||
| } | ||
|
|
||
| public toConditionJson() { |
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
conditionXxmethods to accept an interfaceIConditionExpressioninstead of concrete class and implement this interface by the
Conditionconstruct.
This enables chaining conditions like so:
Fixes #1457
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.