Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fresh GitPod build succeeds but exits with non-zero #8102

Closed
eladb opened this issue May 20, 2020 · 8 comments · Fixed by #8487
Closed

Fresh GitPod build succeeds but exits with non-zero #8102

eladb opened this issue May 20, 2020 · 8 comments · Fixed by #8487
Assignees
@skinny85
Labels
bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p1 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@eladb
Copy link
Contributor

eladb commented May 20, 2020

I've created a fresh GitPod environment from master. Build seems to have succeeded but I still get an error as if it failed.

Reproduction Steps

Kick off a GitPod environment from master.

Error Log

lerna success - @aws-cdk/custom-resources
lerna success - @aws-cdk/cx-api
lerna success - @aws-cdk/example-construct-library
lerna success - @aws-cdk/region-info
lerna success - dns_validated_certificate_handler
lerna success - aws-global-lambda-coordinator
lerna success - @monocdk-experiment/assert
lerna success - @monocdk-experiment/rewrite-imports
lerna success - awslint
lerna success - cdk-build-tools
lerna success - cdk-integ-tools
lerna success - cfn2ts
lerna success - pkglint
lerna success - pkgtools
lerna success - prlint
lerna success - yarn-cling

real    50m7.792s
user    161m8.819s
sys     7m42.627s
❌  Last command failed. Scroll up to see errors in log (search for '!!!!!!!!').
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
gitpod /workspace/aws-cdk $

This is 🐛 Bug Report
@eladb eladb added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 20, 2020
@skinny85
Copy link
Contributor

@eladb can you search for any error messages in the log above? (You might have to scroll up quite a bit - for example, I have a hunch the aws-lambda-nodejs module might be the one that failed)

@eladb
Copy link
Contributor Author

eladb commented May 20, 2020

oh, no docker...?

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label May 27, 2020
@jogold
Copy link
Contributor

jogold commented May 27, 2020

gitpod-io/gitpod#52

@skinny85 skinny85 added the p1 label May 29, 2020
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Jun 11, 2020
@skinny85
chore(s3-deployment): explicitly pass --no-user to pip3 install
f552b34 
Otherwise, the build fails in some enviroments
(for example, Gitpod)
with the error:

ERROR: Can not combine '--user' and '--prefix' as they imply different installation locations

Fixes aws#8102
@skinny85 skinny85 mentioned this issue Jun 11, 2020
Merged
@mergify mergify bot closed this as completed in #8487 Jun 11, 2020
mergify bot pushed a commit that referenced this issue Jun 11, 2020
@skinny85
chore(s3-deployment): explicitly pass --no-user to pip3 install (#8487
36241d1 
)

Otherwise, the build fails in some environments
(for example, Gitpod) with the error:

    ERROR: Can not combine '--user' and '--prefix' as they imply different installation locations

Fixes #8102

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@hoegertn
Copy link
Contributor

@eladb are you sure this is fixed? A fresh Gitpod just failed with

Checking if node is installed... Ok
Checking node version... Ok
Checking if yarn is installed... Ok
Checking yarn version... Ok
Checking if javac is installed... Ok
Checking javac version... Ok
Checking if mvn is installed... Ok
Checking mvn version... Ok
Checking if dotnet is installed... Ok
Checking dotnet version... Ok
Checking if python3 is installed... Ok
Checking python3 version... Ok
Checking if ruby is installed... Ok
Checking ruby version... Ok
Checking if docker is installed... Ok
Checking if docker is running... Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
error Command failed with exit code 1.

@eladb eladb reopened this Jul 29, 2020
@eladb
Copy link
Contributor Author

eladb commented Jul 29, 2020

@skinny85 ?

@skinny85
Copy link
Contributor

Looking.

@skinny85
Copy link
Contributor

Nope, just tried it from clicking the link in our ReadMe on GitHub, everything worked as usual. "Works in my browser!".

@hoegertn that seems like an old master that was before this fix. Can you make sure you're on the newest master, and try again?

@skinny85 skinny85 added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jul 29, 2020
@github-actions
Copy link

github-actions bot commented Aug 6, 2020

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p1 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(s3-deployment): explicitly pass --no-user to pip3 install skinny85/aws-cdk
5 participants
@skinny85 @eladb @hoegertn @jogold @SomayaB