Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn off prerequisite check for Gitpod #9113

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

skinny85
Copy link
Contributor

Gitpod doesn't have a running Docker demon currently,
so the check fails for it.
However, it uses jsii/superchain,
so it's guaranteed to have all of the other required tools.
So, just skip the check for it completely.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Gitpod doesn't have a running Docker demon currently,
so the check fails for it.
However, it uses jsii/superchain,
so it's guaranteed to have all of the other required tools.
So, just skip the check for it completely.
@skinny85 skinny85 requested a review from ericzbeard July 16, 2020 18:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 16, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 216c19c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bb95957 into aws:master Jul 16, 2020
@skinny85 skinny85 deleted the chore/gitpod-prereqs-cjeck-off branch July 16, 2020 20:14
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this pull request Aug 11, 2020
Gitpod doesn't have a running Docker demon currently,
so the check fails for it.
However, it uses jsii/superchain,
so it's guaranteed to have all of the other required tools.
So, just skip the check for it completely.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants