Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Create Python virtual environment in .venv directory #9134

Closed
2 tasks
alexpulver opened this issue Jul 17, 2020 · 2 comments · Fixed by #10995
Closed
2 tasks

[cli] Create Python virtual environment in .venv directory #9134

alexpulver opened this issue Jul 17, 2020 · 2 comments · Fixed by #10995
Assignees
@rix0rrr
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@alexpulver
Copy link
Contributor

cdk init --language python creates virtual environment in .env directory. The ask is to create the virtual environment in .venv directory.

Use Case

Python virtual environment documentation recommends using .venv directory, to prevent clashing with .env environment variable definition files that some tooling supports. .venv is also the default in last PyCharm versions.

Proposed Solution

Modify CDK CLI to create virtual environment in .venv directory

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@alexpulver alexpulver added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 17, 2020
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Jul 17, 2020
@alexpulver alexpulver changed the title [cli] Initialize Python application using Pythonic virtual environment path [cli] Create Python virtual environment in .venv directory Jul 17, 2020
@shivlaks shivlaks added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 5, 2020
@AnderEnder AnderEnder mentioned this issue Oct 20, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 21, 2020
@SomayaB SomayaB assigned rix0rrr and unassigned shivlaks Oct 21, 2020
@mergify mergify bot closed this as completed in #10995 Oct 27, 2020
mergify bot pushed a commit that referenced this issue Oct 27, 2020
@AnderEnder
feat(cli): change virtualenv directory to .venv to comply with python…
a4a41b5 
… recommendation (#10995)

Replace virtualenv directory `.env` to `.venv` for the python templates

Closes #9134

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@alexpulver
Copy link
Contributor Author

Thanks @AnderEnder!

eze1981 pushed a commit to eze1981/aws-cdk-intro-workshop that referenced this issue Nov 4, 2020
fix: virtualenv directory .env to .venv for python workshop
7d4a530 
related to: aws/aws-cdk#9134
@eze1981 eze1981 mentioned this issue Nov 4, 2020
Merged
mergify bot pushed a commit to aws-samples/aws-cdk-intro-workshop that referenced this issue Nov 9, 2020
@eze1981 @NGL321
fix: virtualenv directory .env to .venv for python workshop (#176)
2879384 
* fix: virtualenv directory `.env` to `.venv` for python workshop

related to: aws/aws-cdk#9134

* Update 300-structure.md

Co-authored-by: Ezequiel M Gioia <eze1981@Ezequiels-Mac-mini.local>
Co-authored-by: Noah Litov <noahlitov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
4 participants
@rix0rrr @alexpulver @SomayaB @shivlaks