feat(cli): change virtualenv directory to .venv to comply with python recommendation

[AnderEnder]

Replace virtualenv directory .env to .venv for the python templates

Closes #9134

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[shivlaks]

@AnderEnder changes look good! have you run the yarn integ-init or npm run integ-init script to verify that it still succeeds? (it does not get executed as part of the PR build)

[shivlaks]

thanks for updating this!

[AnderEnder]

have you run the yarn integ-init or npm run integ-init script to verify that it still succeeds? (it does not get executed as part of the PR build)

Unfortunately, I was not able to run it even on master.

$ yarn integ-cli
yarn run v1.22.10
$ npm run integ-cli-regression && npm run integ-cli-no-regression

> aws-cdk@0.0.0 integ-cli-regression /Users/ander/projects/aws-cdk/packages/aws-cdk
> npm run integ-cli-regression-latest-release && npm run integ-cli-regression-latest-code


> aws-cdk@0.0.0 integ-cli-regression-latest-release /Users/ander/projects/aws-cdk/packages/aws-cdk
> test/integ/run-against-dist test/integ/test-cli-regression-against-latest-release.sh

/Users/ander/projects/aws-cdk/packages/aws-cdk does not seem to be a built CDK distribution (change directory or use DIST_ROOT)
/Users/ander/projects/aws-cdk/packages/aws-cdk/test/integ/run-against-dist.bash: line 11: TRAPS[@]: unbound variable

[shivlaks]

have you run the yarn integ-init or npm run integ-init script to verify that it still succeeds? (it does not get executed as part of the PR build)

Unfortunately, I was not able to run it even on master.

$ yarn integ-cli
yarn run v1.22.10
$ npm run integ-cli-regression && npm run integ-cli-no-regression

> aws-cdk@0.0.0 integ-cli-regression /Users/ander/projects/aws-cdk/packages/aws-cdk
> npm run integ-cli-regression-latest-release && npm run integ-cli-regression-latest-code


> aws-cdk@0.0.0 integ-cli-regression-latest-release /Users/ander/projects/aws-cdk/packages/aws-cdk
> test/integ/run-against-dist test/integ/test-cli-regression-against-latest-release.sh

/Users/ander/projects/aws-cdk/packages/aws-cdk does not seem to be a built CDK distribution (change directory or use DIST_ROOT)
/Users/ander/projects/aws-cdk/packages/aws-cdk/test/integ/run-against-dist.bash: line 11: TRAPS[@]: unbound variable

@AnderEnder - i had just the yarn integ-init target in mind as it'll only test the init templates. does that also fail for you?

[AnderEnder]

@AnderEnder - i had just the yarn integ-init target in mind as it'll only test the init templates. does that also fail for you?

@shivlaks, unfortunately, the result is similar:

$ yarn integ-init
yarn run v1.22.10
$ test/integ/run-against-dist test/integ/init/test-all.sh
/Users/ander/projects/aws-cdk/packages/aws-cdk does not seem to be a built CDK distribution (change directory or use DIST_ROOT)
/Users/ander/projects/aws-cdk/packages/aws-cdk/test/integ/run-against-dist.bash: line 11: TRAPS[@]: unbound variable
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[shivlaks]

@AnderEnder - i had just the yarn integ-init target in mind as it'll only test the init templates. does that also fail for you?

@shivlaks, unfortunately, the result is similar:

$ yarn integ-init
yarn run v1.22.10
$ test/integ/run-against-dist test/integ/init/test-all.sh
/Users/ander/projects/aws-cdk/packages/aws-cdk does not seem to be a built CDK distribution (change directory or use DIST_ROOT)
/Users/ander/projects/aws-cdk/packages/aws-cdk/test/integ/run-against-dist.bash: line 11: TRAPS[@]: unbound variable
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@AnderEnder thanks for giving it a shot, that is unfortunate. i'll try to pull this change down and see if I can run it. but as a side note, we probably need to give a little more love in this area so contributors can run them without so much friction...

edit: Oct 26 - will create an issue re: running integ tests locally for the cli - which seems broken

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 6117f1c
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).