Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-eks] use ec2.IVpc for the Pinger #9924

Closed
1 of 2 tasks
pahud opened this issue Aug 24, 2020 · 2 comments · Fixed by #9881
Closed
1 of 2 tasks

[aws-eks] use ec2.IVpc for the Pinger #9924

pahud opened this issue Aug 24, 2020 · 2 comments · Fixed by #9881
Assignees
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@pahud
Copy link
Contributor

pahud commented Aug 24, 2020

The Pinger is using ec2.Vpc as the type of prop.vpc. I guess ec2.IVpc would be enough. In this case we can use the Pinger construct with any existing Vpc. And this helps for PR development.

Use Case

Use the Pinger with any existing Vpc.

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 24, 2020
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Aug 24, 2020
@pahud
Copy link
Contributor Author

pahud commented Aug 24, 2020

Hi @iliapolo

What do you think?

Shall we create a seperate little PR for this or just add this support in #9881 ?

@iliapolo iliapolo added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 24, 2020
@iliapolo
Copy link
Contributor

@pahud It can be part of #9881 no problem 👍

@iliapolo iliapolo added the in-progress This issue is being actively worked on. label Sep 8, 2020
@mergify mergify bot closed this as completed in #9881 Sep 9, 2020
mergify bot pushed a commit that referenced this issue Sep 9, 2020
…ort (#9881)

- This PR allows you to:
1. use `LaunchTemplate` for the managed nodegroups
2. specify custom AMI in the `LaunchTemplate`

- `prop.vpc` of Pinger is now `ec2.IVpc`
- bump cluster k8s version in the integration testing from `1.16` to `1.17`

Closes: #9873 
Closes: #9924

## Note

At this moment we use the property override to make it work. When cfn spec is updated we can use `CfnNodeGroup` to specify launch template natively, which should be backward-compatible with no breaking changes.

Users will need to create `CfnLaunchTemplate` resource and pass the resource as the property to the nodegroup untill we support the LaunchTemplate L2(#6734).

## TODO

- [x] integ testing
- [x] unit testing
- [x] update README


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iliapolo iliapolo removed the in-progress This issue is being actively worked on. label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants