Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): managed nodegroup with custom AMI and launch template support #9881

Merged
merged 15 commits into from
Sep 9, 2020
Merged

feat(eks): managed nodegroup with custom AMI and launch template support #9881

merged 15 commits into from
Sep 9, 2020

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Aug 21, 2020

  • This PR allows you to:
  1. use LaunchTemplate for the managed nodegroups
  2. specify custom AMI in the LaunchTemplate
  • prop.vpc of Pinger is now ec2.IVpc
  • bump cluster k8s version in the integration testing from 1.16 to 1.17

Closes: #9873
Closes: #9924

Note

At this moment we use the property override to make it work. When cfn spec is updated we can use CfnNodeGroup to specify launch template natively, which should be backward-compatible with no breaking changes.

Users will need to create CfnLaunchTemplate resource and pass the resource as the property to the nodegroup untill we support the LaunchTemplate L2(#6734).

TODO

  • integ testing
  • unit testing
  • update README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@pahud pahud marked this pull request as draft August 21, 2020 01:12
@pahud pahud marked this pull request as ready for review August 23, 2020 13:43
@pahud pahud mentioned this pull request Aug 24, 2020
2 tasks
@pahud
Copy link
Contributor Author

pahud commented Aug 24, 2020

Hi @iliapolo

I am ready for the first round.

eladb
eladb previously requested changes Sep 1, 2020
packages/@aws-cdk/aws-eks/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-eks/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts Outdated Show resolved Hide resolved
@eladb
Copy link
Contributor

eladb commented Sep 3, 2020

Ping

@pahud
Copy link
Contributor Author

pahud commented Sep 4, 2020

Thanks for the review. WIP 👍

@mergify mergify bot dismissed eladb’s stale review September 4, 2020 16:55

Pull request has been modified.

@pahud pahud requested a review from eladb September 4, 2020 23:30
@eladb eladb assigned iliapolo and unassigned eladb Sep 7, 2020
@eladb eladb requested review from iliapolo and removed request for eladb September 7, 2020 09:41
packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-eks/lib/managed-nodegroup.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed iliapolo’s stale review September 8, 2020 16:30

Pull request has been modified.

@pahud
Copy link
Contributor Author

pahud commented Sep 8, 2020

fixing the integ now

@iliapolo
Copy link
Contributor

iliapolo commented Sep 8, 2020

@pahud Should i review again?

@pahud
Copy link
Contributor Author

pahud commented Sep 8, 2020

@pahud Should i review again?

Yes, should all resolved. Please check it out again. Thanks.

@pahud
Copy link
Contributor Author

pahud commented Sep 8, 2020

@iliapolo I'm ready.

@rameshmimit
Copy link

We are working for a big client and kinda waiting for this feature to release. Can I request the reviewers(@eladb @iliapolo @statik ) to get it reviewed again and hopefully merge it as soon as possible.

@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@iliapolo iliapolo added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels Sep 9, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2aa2463
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5c294fb into aws:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants