-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): managed nodegroup with custom AMI and launch template support #9881
Conversation
Hi @iliapolo I am ready for the first round. |
Ping |
Thanks for the review. WIP 👍 |
Pull request has been modified.
fixing the integ now |
@pahud Should i review again? |
Yes, should all resolved. Please check it out again. Thanks. |
@iliapolo I'm ready. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
LaunchTemplate
for the managed nodegroupsLaunchTemplate
prop.vpc
of Pinger is nowec2.IVpc
1.16
to1.17
Closes: #9873
Closes: #9924
Note
At this moment we use the property override to make it work. When cfn spec is updated we can use
CfnNodeGroup
to specify launch template natively, which should be backward-compatible with no breaking changes.Users will need to create
CfnLaunchTemplate
resource and pass the resource as the property to the nodegroup untill we support the LaunchTemplate L2(#6734).TODO
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license