Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appsync): add support for subscriptions for code-first schema generation #10078

Merged
merged 27 commits into from
Sep 11, 2020
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
de064ac
prelim addition of subscriptions
BryanPan342 Aug 31, 2020
f3838ef
first pass changes to readme
BryanPan342 Aug 31, 2020
f3c77e3
refactor(appsync): graphQLApi to graphqlApi for better snakecasing
BryanPan342 Aug 31, 2020
51edc01
Revert "refactor(appsync): graphQLApi to graphqlApi for better snakec…
BryanPan342 Aug 31, 2020
884e185
Merge remote-tracking branch 'upstream/master'
BryanPan342 Aug 31, 2020
9ad9d36
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 1, 2020
d9ebafb
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 1, 2020
64db87e
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 1, 2020
b3622b0
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 1, 2020
4cdd244
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 2, 2020
6608704
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 3, 2020
f85ce81
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 4, 2020
d6c4d1e
Merge branch 'master' into subscription
BryanPan342 Sep 4, 2020
4f32d9d
integ changes
BryanPan342 Sep 4, 2020
69eb74b
add directives for subscriptions
BryanPan342 Sep 4, 2020
2b6d915
update readme with directive
BryanPan342 Sep 4, 2020
e8cfc0c
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 8, 2020
1423bc6
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 8, 2020
2ea72ed
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 8, 2020
5b3e44d
edit readme
BryanPan342 Sep 9, 2020
322d9a1
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 9, 2020
0f1b683
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 10, 2020
7495b0f
address suggestions
BryanPan342 Sep 10, 2020
8b087ef
Merge branch 'master' into subscription
BryanPan342 Sep 10, 2020
d1f4956
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 11, 2020
056df67
Merge remote-tracking branch 'upstream/master'
BryanPan342 Sep 11, 2020
f5bced6
Merge branch 'master' into subscription
BryanPan342 Sep 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
edit readme
BryanPan342 committed Sep 9, 2020
commit 5b3e44dd30e29092ec57df433d92b1dd0c555c3e
5 changes: 3 additions & 2 deletions packages/@aws-cdk/aws-appsync/README.md
Original file line number Diff line number Diff line change
@@ -640,8 +640,9 @@ To learn more about top level operations, check out the docs [here](https://docs
#### Subscription

Every schema **can** have a top level Subscription type. The top level `Subscription` Type
is the only exposed type that users can access to invoke a response to a mutation. This means
you can make any data source real time by specificy a GraphQL Schema directive on a mutation.
is the only exposed type that users can access to invoke a response to a mutation. `Subscriptions`
notify users when a mutation specific mutation is called. This means you can make any data source
real time by specificy a GraphQL Schema directive on a mutation.

**Note**: The AWS AppSync client SDK automatically handles subscription connection management.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this something users need to consider when using subscriptions? it's not something they can affect in through their CDK app right?

Copy link
Contributor Author

@BryanPan342 BryanPan342 Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think its nice to have something here because subscriptions are unique to AppSync. Thus for a new person scanning over the README, it would be nice to get a gloss of how that would work.