Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appsync): add support for subscriptions for code-first schema generation #10078
feat(appsync): add support for subscriptions for code-first schema generation #10078
Changes from all commits
de064ac
f3838ef
f3c77e3
51edc01
884e185
9ad9d36
d9ebafb
64db87e
b3622b0
4cdd244
6608704
f85ce81
d6c4d1e
4f32d9d
69eb74b
2b6d915
e8cfc0c
1423bc6
2ea72ed
5b3e44d
322d9a1
0f1b683
7495b0f
8b087ef
d1f4956
056df67
f5bced6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this something users need to consider when using subscriptions? it's not something they can affect in through their CDK app right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think its nice to have something here because subscriptions are unique to AppSync. Thus for a new person scanning over the README, it would be nice to get a gloss of how that would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any additional changes to the verification steps because of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless we want to build out an entire app to check if subscriptions work then no..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually nvm here is a solution
https://stackoverflow.com/questions/52567681/how-to-test-subscription-in-aws-appsync-console
and another link to testing in general
https://docs.aws.amazon.com/appsync/latest/devguide/test-debug-resolvers.html