chore(cli): "cdk context" is broken #10751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shivlaks
approved these changes
Oct 7, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
diesal11
pushed a commit
to diesal11/aws-cdk
that referenced
this pull request
Oct 7, 2020
This [commit](aws#10619), while fixed the problem mentioned, broke the simplest functionally of: ``` cdk context ``` Now throws: ``` Cannot read property 'sort' of undefined ``` This PR reverts that change, and adds a simple unit test that will allow detecting this kind of breakage in unit tests. We still need to fix the issue in the PR, opening the orginal [issue](aws#3033). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit, while fixed the problem mentioned, broke the simplest functionally of:
Now throws:
This PR reverts that change, and adds a simple unit test that will allow detecting this kind of breakage in unit tests.
We still need to fix the issue in the PR, opening the orginal issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license