feat(appmesh): change Route's spec to a union-like class #11343
Conversation
|
|
| abstract readonly weightedTargets: WeightedTarget[]; | ||
|
|
||
| /** | ||
| * The priority for the route. Routes are matched based on the specified value, where 0 is the highest priority | ||
| */ | ||
| abstract readonly priority?: number; |
There was a problem hiding this comment.
Why are we exposing these - I don't see them used in Route...? I think we only need bind() in this class, no?
We should strive to minimize the public API surface as much as we can.
There was a problem hiding this comment.
So, this field makes a bit more sense once we implement header based routing for HTTP.
Essentially it is used to disambiguate when a request matches multiple routes. I'll remove for this PR and we can add it back later!
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
skinny85
changed the title
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Implements the same pattern
GatewayRoutesuse for defining protocol specific specs.Adds GRPC and HTTP2 support to Routes which will resolve #9755
BREAKING CHANGE: changes Route's spec to a union-like class. RouteSpec is now defined using protocol variant static methods
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license