New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda-event-sources): msk and self-managed kafka event sources #12507

Merged

mergify merged 59 commits into aws:master from bracki:kafka-lambda-event-source

Mar 16, 2021

Contributor

bracki commented Jan 14, 2021

Fixes #12099

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io bot commented Jan 14, 2021 •

edited

Loading

github-actions bot added the @aws-cdk/aws-lambda-event-sources label

github-actions bot assigned nija-at

Contributor

mergify bot commented Jan 14, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

bracki changed the title ~~(lambda-event-sources): Implement Lambda event source for Kafka~~ feat(lambda-event-sources): Implement Lambda event source for Kafka

bracki force-pushed the kafka-lambda-event-source branch 3 times, most recently from c6e5881 to 92e6592 Compare

January 18, 2021 11:56

nija-at previously requested changes

View reviewed changes

Contributor

nija-at left a comment

Thanks for submitting this PR! 😊
First round of comments below.

packages/@aws-cdk/aws-lambda-event-sources/README.md Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/README.md Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/package.json Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/test/test.kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved

mergify bot dismissed nija-at’s stale review

January 18, 2021 13:12

Pull request has been modified.

bracki force-pushed the kafka-lambda-event-source branch from 2e6e6df to c90691f Compare

January 18, 2021 14:07

bracki commented

View reviewed changes

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved

bracki force-pushed the kafka-lambda-event-source branch from 7f5e7bb to cf2bc52 Compare

January 19, 2021 14:07

bracki requested a review from nija-at

January 19, 2021 16:57

Contributor Author

bracki commented Jan 19, 2021 •

edited

Loading

I think I addressed your feedback @nija-at. EventSourceMappingOptions is a bit bloated now, but I don't see the benefit of flattening everything as mentioned in the design docs, because I believe you/somebody shouldn't use this directly. That's what the event sources are for.

Contributor

nija-at commented Jan 25, 2021

Hey @bracki - sorry for the delay to get back to this.
I had a very busy last week, and I'm afraid this week is going to be the same. I'll get back on this PR as soon as I'm able (likely early next week).

Thanks for your patience.

bracki force-pushed the kafka-lambda-event-source branch 2 times, most recently from 26668b7 to d40bc2c Compare

February 4, 2021 09:22

nija-at previously requested changes

View reviewed changes

Contributor

nija-at left a comment

Hey @bracki - Sorry to have left this languishing. I've taken another look and comments are below.

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved

nija-at reviewed

View reviewed changes

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved

nija-at changed the title ~~feat(lambda-event-sources): Implement Lambda event source for Kafka~~ feat(lambda-event-sources): msk and self managed kafka event sources

nija-at changed the title ~~feat(lambda-event-sources): msk and self managed kafka event sources~~ feat(lambda-event-sources): msk and self-managed kafka event sources

bracki force-pushed the kafka-lambda-event-source branch from d40bc2c to f73eaef Compare

February 11, 2021 19:11

mergify bot dismissed nija-at’s stale review

February 11, 2021 19:12

Pull request has been modified.

Contributor Author

bracki commented Feb 11, 2021

@nija-at All feedback addressed, apart from the JSII thing and the ICluster.

bracki force-pushed the kafka-lambda-event-source branch from f7d8775 to 76e40ac Compare

February 12, 2021 11:16

nija-at previously requested changes

View reviewed changes

Contributor

nija-at left a comment •

edited

Loading

Thanks for the changes @bracki. See my comments below.

Could you address - #12507 (comment)

packages/@aws-cdk/aws-lambda-event-sources/README.md Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/README.md Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda-event-sources/test/test.kafka.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved

gitpod-io bot commented Feb 16, 2021 •

edited

Loading

mergify bot dismissed nija-at’s stale review

February 16, 2021 16:28

Pull request has been modified.

bracki force-pushed the kafka-lambda-event-source branch from 8c2ebbc to 18e4073 Compare

February 16, 2021 20:28

bracki and others added 13 commits

March 16, 2021 10:27


          Remove verbose docs

fd318c8


          Update packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts

439e0c6

Co-authored-by: Niranjan Jayakar <nija@amazon.com>


          Fix typo

c0d6006


          Apply feedback

4a18ce7


          Extract method

b2c9145


          Update packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts

87dcaec

Co-authored-by: Niranjan Jayakar <nija@amazon.com>


          Reorganize

8d5d938


          rename tests

b6be30a


          Fix and extract

14c0876


          Add more tests

838d43f


          Remove obsolete dependency

a177e0d


          Apply feedback

6f451cf


          Rearrange tests

be2b531

bracki force-pushed the kafka-lambda-event-source branch from 6b9fea5 to be2b531 Compare

March 16, 2021 09:49

mergify bot dismissed nija-at’s stale review

March 16, 2021 09:50

Pull request has been modified.

nija-at approved these changes

View reviewed changes

Contributor

nija-at left a comment

Awesome!

Contributor

mergify bot commented Mar 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).


          Merge branch 'master' into kafka-lambda-event-source

2bae12c

Contributor

mergify bot commented Mar 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).


          Merge branch 'master' into kafka-lambda-event-source

Contributor

mergify bot commented Mar 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).


          Merge branch 'master' into kafka-lambda-event-source

5793e65

Contributor

mergify bot commented Mar 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).


          Merge branch 'master' into kafka-lambda-event-source

5506cc1

Collaborator

aws-cdk-automation commented Mar 16, 2021

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: 5506cc1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Contributor

mergify bot commented Mar 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot merged commit 73209e1 into aws:master

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request


          feat(lambda-event-sources): msk and self-managed kafka event sources (a…

99d83e9

…ws#12507)

Fixes aws#12099 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request


          feat(lambda-event-sources): msk and self-managed kafka event sources (a…

…ws#12507)

Fixes aws#12099 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request


          feat(lambda-event-sources): msk and self-managed kafka event sources (a…

6ab4f1f

…ws#12507)

Fixes aws#12099 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-lambda-event-sources