Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda): invalid python sample code generated #13038

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Feb 14, 2021

Following up on #13036 with an additional instance in which rosetta fails to generate correct python code (aws/jsii#2569).

Fixes #13035


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Following up on #13036 with an additional instance in which rosetta fails to generate correct python code.

Fixes #13035
@gitpod-io
Copy link

gitpod-io bot commented Feb 14, 2021

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Feb 14, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 14, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 5ec40f7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bef0e84 into master Feb 14, 2021
@mergify mergify bot deleted the eladb-patch-1 branch February 14, 2021 15:00
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
Following up on aws#13036 with an additional instance in which rosetta fails to generate correct python code (aws/jsii#2569).

Fixes aws#13035


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDK integration tests are broken due to invalid newline handling in python sample code
4 participants