-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(guidelines): guidance on which constructs are included in the CDK #13218
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
09be729
chore: design guidance on construct abstraction and inclusion in the CDK
njlynch e9ea0ac
dramatically simplify criteria
njlynch f5bce0f
Merge remote-tracking branch 'origin/master' into njlynch/l2-criteria
njlynch 853fda4
Merge remote-tracking branch 'origin/master' into njlynch/l2-criteria
njlynch 1b9344d
Moved section, changed title, added deprecation note for L3s
njlynch 1f41c21
Apply suggestions from code review
njlynch 4e1c53c
Fixed TOC. Examples of L2.5s and L3
njlynch 622994e
Merge remote-tracking branch 'origin/master' into njlynch/l2-criteria
njlynch e308778
Update DESIGN_GUIDELINES.md
d092144
Merge branch 'master' into njlynch/l2-criteria
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth mentioning that L2 resources interact with other CloudFormation resources only via other L2s, never via L1s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely worth capturing somewhere in this doc, but I'm not sure if this is the right section. Maybe under the
Props
section, orImplementation
, depending on if we're talking about the public surface area or implementation details?