chore: produce go bindings #13317
Merged
chore: produce go bindings #13317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `go.moduleName` entry to all package.json files which will cause jsii-pacmak to produce go bindings for the AWS CDK and place them under the `dist/go` directory during packaging. Resolves aws/jsii#2611
|
|
basically just reflect the same module name
RomainMuller
reviewed
Mar 2, 2021
Yes, this is intentional. |
RomainMuller
reviewed
Mar 2, 2021
RomainMuller
reviewed
Mar 2, 2021
iliapolo
reviewed
Mar 2, 2021
RomainMuller
approved these changes
Mar 2, 2021
iliapolo
approved these changes
Mar 2, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2021
This reverts commit e8f0c3c due to some issue in go code generation (namely aws/jsii#2638 and aws/jsii#2637) and unacceptable build performance for producing bindings for all CDK modules. Our plan is to fix the relevant issues and only produce go bindings for monocdk instead of all modules. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
cornerwings
pushed a commit
to cornerwings/aws-cdk
that referenced
this pull request
Mar 8, 2021
Adds a `go.moduleName` entry to all package.json files which will cause jsii-pacmak to produce go bindings for the AWS CDK and place them under the `dist/go` directory during packaging. Resolves aws/jsii#2611 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
cornerwings
pushed a commit
to cornerwings/aws-cdk
that referenced
this pull request
Mar 8, 2021
This reverts commit e8f0c3c due to some issue in go code generation (namely aws/jsii#2638 and aws/jsii#2637) and unacceptable build performance for producing bindings for all CDK modules. Our plan is to fix the relevant issues and only produce go bindings for monocdk instead of all modules. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
go.moduleNameentry to all package.json files which will cause jsii-pacmak to produce go bindings for the AWS CDK and place them under thedist/godirectory during packaging.Resolves aws/jsii#2611
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license