go: malformed constructor docstring with period #2638

eladb · 2021-03-03T07:59:03Z

🐛 Bug Report

Affected Languages

General Information

JSII Version: 1.23.0
Platform: any

What is the problem?

Consider the following jsii code:

export class MyClass {
  /**
   * Build a new condition. The condition must be constructed with a condition token,
   * that the condition is based on.
   */
  constructor() {

  }
}

Error:

./godefault.go:19:1: syntax error: non-declaration statement outside function body

Verbose Log

Generated output:

The text was updated successfully, but these errors were encountered:

Use `documenter.emit()`, which takes care of multi-line docstrings instead of just emitting the text. This uncovered missing maturity information on ctors as well. Fixes #2638

This reverts commit e8f0c3c due to some issue in go code generation (namely aws/jsii#2638 and aws/jsii#2637) and unacceptable build performance for producing bindings for all CDK modules. Our plan is to fix the relevant issues and only produce go bindings for monocdk instead of all modules. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Use `documenter.emit()`, which takes care of multi-line docstrings instead of just emitting the text. This uncovered missing maturity information on ctors as well. Fixes #2638

github-actions · 2021-03-03T12:36:35Z

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This reverts commit e8f0c3c due to some issue in go code generation (namely aws/jsii#2638 and aws/jsii#2637) and unacceptable build performance for producing bindings for all CDK modules. Our plan is to fix the relevant issues and only produce go bindings for monocdk instead of all modules. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

eladb added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 3, 2021

eladb changed the title ~~go: malformed multiline docstring generated after "."~~ go: malformed constructor docstring with period Mar 3, 2021

eladb mentioned this issue Mar 3, 2021

fix(go): malformed multiline docstrings in constructors #2639

Merged

eladb self-assigned this Mar 3, 2021

eladb mentioned this issue Mar 3, 2021

chore: revert "produce go bindings (#13317)" aws/aws-cdk#13362

Merged

eladb added effort/small Small work item – less than a day of effort p1 labels Mar 3, 2021

eladb closed this as completed in #2639 Mar 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

go: malformed constructor docstring with period #2638

go: malformed constructor docstring with period #2638

eladb commented Mar 3, 2021

github-actions bot commented Mar 3, 2021