feat(appmesh): add missing route match features #13350

misterjoshua · 2021-03-02T17:45:22Z

Adds route priority, header matching and matching by scheme and method.

Closes #11645

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2021-03-02T17:45:25Z

skinny85

Generally looks great @misterjoshua !

Couple of minor comments/questions.

packages/@aws-cdk/aws-appmesh/lib/route-spec.ts

Pull request has been modified.

misterjoshua · 2021-03-04T04:01:40Z

@skinny85 I've changed the header matching to your HeaderMatch bind pattern. I had to make a few judgement calls in type naming and HeaderMatchConfig properties. I went with valueInRange and valueNotInRange for the reason I mentioned above, but I have no strong objection to switching to valueIsBetween and valueIsNotBetween in case you have a strong opinion there. Let me know if there's anything else you need. Thanks

alexbrjo

LGTM - Thanks for the well written PR!

packages/@aws-cdk/aws-appmesh/lib/route-spec.ts

skinny85

Looks great @misterjoshua ! Some minor documentation and naming changes that I feel like are needed before merging.

packages/@aws-cdk/aws-appmesh/lib/route-spec.ts

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@aws-cdk/core](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/core) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/core's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/core's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/core">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@aws-cdk/core&package-manager=npm_and_yarn&previous-version=1.93.0&new-version=1.94.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [aws-cdk](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases">aws-cdk's releases</a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md">aws-cdk's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/aws-cdk">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=aws-cdk&package-manager=npm_and_yarn&previous-version=1.93.0&new-version=1.94.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@aws-cdk/assert](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/assert) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/assert's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/assert's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/assert">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@aws-cdk/assert&package-manager=npm_and_yarn&previous-version=1.93.0&new-version=1.94.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

feat: add missing route match features

9417d0a

misterjoshua changed the title ~~feat: add missing route match features~~ feat(appmesh): add missing route match features Mar 2, 2021

github-actions bot added the @aws-cdk/aws-appmesh Related to AWS App Mesh label Mar 2, 2021

github-actions bot assigned skinny85 Mar 2, 2021

misterjoshua added 4 commits March 2, 2021 10:59

fix: use a more sensible example

40cd42a

refactor: renderMatch -> renderMatchMethod

612de8d

feat: add routespec priority

d930e92

style: enum spacing

5766d54

skinny85 previously requested changes Mar 4, 2021

View reviewed changes

packages/@aws-cdk/aws-appmesh/lib/route-spec.ts Show resolved Hide resolved

packages/@aws-cdk/aws-appmesh/lib/route-spec.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-appmesh/lib/route-spec.ts Outdated Show resolved Hide resolved

implement review changes

82e8096

update the readme example

5258a65

misterjoshua requested a review from skinny85 March 4, 2021 04:01

docs: add call-out for header logical and

68c4171

alexbrjo approved these changes Mar 6, 2021

View reviewed changes

packages/@aws-cdk/aws-appmesh/lib/route-spec.ts Outdated Show resolved Hide resolved

Merge branch 'master' into missing-route-match

4107fd0

skinny85 previously requested changes Mar 9, 2021

View reviewed changes

skinny85 reviewed Mar 9, 2021

View reviewed changes

packages/@aws-cdk/aws-appmesh/lib/route-spec.ts Show resolved Hide resolved

misterjoshua added 10 commits March 8, 2021 18:59

docs: http request method review changes

6f0473c

refactor: scheme -> protocol

44ea443

docs: improve wording for HttpRouteMatchMethod

5ba27a6

refactor: HeaderMatchConfig.name -> headerName

17c703d

refactor: name -> headerName for all factory methods, add params to docs

700cd83

refactor: HttpRouteMatchScheme -> HttpRouteProtocol

8e6758b

docs: improve HeaderMatch comments and variable names

7441bb6

refactor: inline the headers variable

60e787c

docs: remove the jsdocs on the internal HttpRouteSpec

4940157

refactor: use only httpRouteHeader in HeaderMatchConfig

88c24be

This was referenced Mar 17, 2021

chore(deps): Bump @aws-cdk/aws-s3 from 1.93.0 to 1.94.1 SnapPetal/cdk-simplewebsite-deploy#156

Closed

Bump aws-cdk from 1.76.0 to 1.94.1 covertbert/shared-aws-infra#143

Closed

dependabot bot mentioned this pull request Mar 17, 2021

build(deps): bump @aws-cdk/core from 1.93.0 to 1.94.1 wheatstalk/oidc-mock#14

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(appmesh): add missing route match features #13350

feat(appmesh): add missing route match features #13350

misterjoshua commented Mar 2, 2021 •

edited

Loading

gitpod-io bot commented Mar 2, 2021 •

edited

Loading

skinny85 left a comment

misterjoshua commented Mar 4, 2021

alexbrjo left a comment •

edited

Loading

skinny85 left a comment

feat(appmesh): add missing route match features #13350

feat(appmesh): add missing route match features #13350

Conversation

misterjoshua commented Mar 2, 2021 • edited Loading

gitpod-io bot commented Mar 2, 2021 • edited Loading

skinny85 left a comment

Choose a reason for hiding this comment

misterjoshua commented Mar 4, 2021

alexbrjo left a comment • edited Loading

Choose a reason for hiding this comment

skinny85 left a comment

Choose a reason for hiding this comment

misterjoshua commented Mar 2, 2021 •

edited

Loading

gitpod-io bot commented Mar 2, 2021 •

edited

Loading

alexbrjo left a comment •

edited

Loading