Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appmesh): add missing route match features #13350

Merged
merged 21 commits into from
Mar 11, 2021
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9417d0a
feat: add missing route match features
misterjoshua Mar 2, 2021
40cd42a
fix: use a more sensible example
misterjoshua Mar 2, 2021
612de8d
refactor: renderMatch -> renderMatchMethod
misterjoshua Mar 2, 2021
d930e92
feat: add routespec priority
misterjoshua Mar 2, 2021
5766d54
style: enum spacing
misterjoshua Mar 3, 2021
82e8096
implement review changes
misterjoshua Mar 4, 2021
5258a65
update the readme example
misterjoshua Mar 4, 2021
68c4171
docs: add call-out for header logical and
misterjoshua Mar 4, 2021
4107fd0
Merge branch 'master' into missing-route-match
misterjoshua Mar 8, 2021
6f0473c
docs: http request method review changes
misterjoshua Mar 9, 2021
44ea443
refactor: scheme -> protocol
misterjoshua Mar 9, 2021
5ba27a6
docs: improve wording for HttpRouteMatchMethod
misterjoshua Mar 9, 2021
17c703d
refactor: HeaderMatchConfig.name -> headerName
misterjoshua Mar 9, 2021
700cd83
refactor: name -> headerName for all factory methods, add params to docs
misterjoshua Mar 9, 2021
8e6758b
refactor: HttpRouteMatchScheme -> HttpRouteProtocol
misterjoshua Mar 9, 2021
7441bb6
docs: improve HeaderMatch comments and variable names
misterjoshua Mar 9, 2021
60e787c
refactor: inline the headers variable
misterjoshua Mar 9, 2021
4940157
docs: remove the jsdocs on the internal HttpRouteSpec
misterjoshua Mar 9, 2021
88c24be
refactor: use only httpRouteHeader in HeaderMatchConfig
misterjoshua Mar 9, 2021
e7b8ca4
perform review changes
misterjoshua Mar 11, 2021
cb9012e
Merge branch 'master' of github.com:aws/aws-cdk into missing-route-match
misterjoshua Mar 11, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/@aws-cdk/aws-appmesh/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,30 @@ router.addRoute('route-http', {
});
```

Add an HTTP2 route that matches based on method, scheme and header:

```ts
router.addRoute('route-http2', {
routeSpec: appmesh.RouteSpec.http2({
weightedTargets: [
{
virtualNode: node,
},
],
match: {
prefixPath: '/path-to-app',
method: appmesh.HttpRouteMatchMethod.POST,
scheme: appmesh.HttpRouteMatchScheme.HTTPS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe those are now out of the date, with the recent name changes.

headers: [
// All specified headers must match for the route to match.
appmesh.HeaderMatch.valueStartsWith('Content-Type', 'application/json'),
appmesh.HeaderMatch.valueIsNot('Content-Type', 'application/json+unsupported'),
]
},
}),
});
```

Add a single route with multiple targets and split traffic 50/50

```ts
Expand Down
Loading