-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appmesh): add missing route match features #13350
Merged
Merged
Changes from 8 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
9417d0a
feat: add missing route match features
misterjoshua 40cd42a
fix: use a more sensible example
misterjoshua 612de8d
refactor: renderMatch -> renderMatchMethod
misterjoshua d930e92
feat: add routespec priority
misterjoshua 5766d54
style: enum spacing
misterjoshua 82e8096
implement review changes
misterjoshua 5258a65
update the readme example
misterjoshua 68c4171
docs: add call-out for header logical and
misterjoshua 4107fd0
Merge branch 'master' into missing-route-match
misterjoshua 6f0473c
docs: http request method review changes
misterjoshua 44ea443
refactor: scheme -> protocol
misterjoshua 5ba27a6
docs: improve wording for HttpRouteMatchMethod
misterjoshua 17c703d
refactor: HeaderMatchConfig.name -> headerName
misterjoshua 700cd83
refactor: name -> headerName for all factory methods, add params to docs
misterjoshua 8e6758b
refactor: HttpRouteMatchScheme -> HttpRouteProtocol
misterjoshua 7441bb6
docs: improve HeaderMatch comments and variable names
misterjoshua 60e787c
refactor: inline the headers variable
misterjoshua 4940157
docs: remove the jsdocs on the internal HttpRouteSpec
misterjoshua 88c24be
refactor: use only httpRouteHeader in HeaderMatchConfig
misterjoshua e7b8ca4
perform review changes
misterjoshua cb9012e
Merge branch 'master' of github.com:aws/aws-cdk into missing-route-match
misterjoshua File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe those are now out of the date, with the recent name changes.