Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): oidc-provider can't pull from hosts requiring SNI #13397

Merged
merged 3 commits into from
Mar 8, 2021
Merged

fix(iam): oidc-provider can't pull from hosts requiring SNI #13397

merged 3 commits into from
Mar 8, 2021

Conversation

creiche
Copy link
Contributor

@creiche creiche commented Mar 4, 2021

This enables SNI when the oidcProvider tries to pull the thumbprint from a server in the downloadThumbprint function. This fixes issues when trying to add an oidcProvider that is using SNI.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 4, 2021

@creiche creiche changed the title enable SNI on oidc-provider fix(aws-iam): enable SNI on oidc-provider Mar 4, 2021
@github-actions github-actions bot added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Mar 4, 2021
@rix0rrr rix0rrr changed the title fix(aws-iam): enable SNI on oidc-provider fix(iam): oidc-provider does not work with SNI hosts Mar 8, 2021
@rix0rrr rix0rrr changed the title fix(iam): oidc-provider does not work with SNI hosts fix(iam): oidc-provider does not work hosts requiring SNI Mar 8, 2021
@rix0rrr rix0rrr changed the title fix(iam): oidc-provider does not work hosts requiring SNI fix(iam): oidc-provider does not work with hosts requiring SNI Mar 8, 2021
@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Mar 8, 2021
@rix0rrr rix0rrr changed the title fix(iam): oidc-provider does not work with hosts requiring SNI fix(iam): oidc-provider can't pull from hosts requiring SNI Mar 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7ccb820
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 90dbfb5 into aws:master Mar 8, 2021
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
This enables SNI when the oidcProvider tries to pull the thumbprint from a server in the downloadThumbprint function.  This fixes issues when trying to add an oidcProvider that is using SNI.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants