Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): incorrect values for prop UntrustedArtifactOnDeployment #13667

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Mar 18, 2021

The allowed values for UntrustedArtifactOnDeployment in the
AWS::Lambda::CodeSigningConfig resource type are 'Warn' and 'Enforce'.

This was incorrectly set in the CDK.

fixes #13586


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The allowed values for `UntrustedArtifactOnDeployment` in the
`AWS::Lambda::CodeSigningConfig` resource type are 'Warn' and 'Enforce'.

This was incorrectly set in the CDK.

fixes #13586
@nija-at nija-at requested a review from a team March 18, 2021 11:43
@nija-at nija-at self-assigned this Mar 18, 2021
@gitpod-io
Copy link

gitpod-io bot commented Mar 18, 2021

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Mar 18, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 18, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e7f71d8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0757686 into master Mar 19, 2021
@mergify mergify bot deleted the nija-at/lamda-incorrect-enum-val branch March 19, 2021 00:24
eladb pushed a commit that referenced this pull request Mar 24, 2021
…13667)

The allowed values for `UntrustedArtifactOnDeployment` in the
`AWS::Lambda::CodeSigningConfig` resource type are 'Warn' and 'Enforce'.

This was incorrectly set in the CDK.

fixes #13586


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…ws#13667)

The allowed values for `UntrustedArtifactOnDeployment` in the
`AWS::Lambda::CodeSigningConfig` resource type are 'Warn' and 'Enforce'.

This was incorrectly set in the CDK.

fixes aws#13586


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Lambda): CodeSigningConfig UntrustedArtifactOnDeployment using incorrect string
3 participants