feat(route53): add support for parentHostedZoneName for CrossAccountZoneDelegationRecord #14097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@njlynch This is the follow up to the previous change for |
njlynch
reviewed
Apr 20, 2021
packages/@aws-cdk/aws-route53/lib/cross-account-zone-delegation-handler/index.ts
Show resolved
Hide resolved
njlynch
previously requested changes
Apr 27, 2021
…oneDelegationRecord
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
…oneDelegationRecord (aws#14097) feat(route53): add support for parentHostedZoneName for CrossAccountZoneDelegationRecord 1. Zone name lookup: The current implementation of `CrossAccountZoneDelegationRecord` requires users to pass the `parentHostedZoneId` which is not so easy since we cannot pass references cross account. This implementation lets them pass the zone name and queries the route53 API to get the zoneId. 2. Delegation role name addition The ARN of the delegation role cannot be passed around to stacks since they will have different environments (this is cross account delegation and CDK does not allow passing references across environments). This means that users need to import the delegation role in the stack containing the child zone. Since it needs to be imported, the users would need the role ARN. Now this ARN can either be hard-coded or constructed. Hard-coding the ARN is not entirely feasible since that would require deploying the parent stack first, then making code change and then deploying child stack in pipelines. With role name, the ARN can be easily constructed (refer readme for importing role) and it provides a better user experience. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…oneDelegationRecord (aws#14097) feat(route53): add support for parentHostedZoneName for CrossAccountZoneDelegationRecord 1. Zone name lookup: The current implementation of `CrossAccountZoneDelegationRecord` requires users to pass the `parentHostedZoneId` which is not so easy since we cannot pass references cross account. This implementation lets them pass the zone name and queries the route53 API to get the zoneId. 2. Delegation role name addition The ARN of the delegation role cannot be passed around to stacks since they will have different environments (this is cross account delegation and CDK does not allow passing references across environments). This means that users need to import the delegation role in the stack containing the child zone. Since it needs to be imported, the users would need the role ARN. Now this ARN can either be hard-coded or constructed. Hard-coding the ARN is not entirely feasible since that would require deploying the parent stack first, then making code change and then deploying child stack in pipelines. With role name, the ARN can be easily constructed (refer readme for importing role) and it provides a better user experience. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(route53): add support for parentHostedZoneName for CrossAccountZoneDelegationRecord
The current implementation of
CrossAccountZoneDelegationRecordrequires users to pass theparentHostedZoneIdwhich is not so easy since we cannot pass references cross account.This implementation lets them pass the zone name and queries the route53 API to get the zoneId.
The ARN of the delegation role cannot be passed around to stacks since they will have different environments (this is cross account delegation and CDK does not allow passing references across environments).
This means that users need to import the delegation role in the stack containing the child zone. Since it needs to be imported, the users would need the role ARN. Now this ARN can either be hard-coded or constructed. Hard-coding the ARN is not entirely feasible since that would require deploying the parent stack first, then making code change and then deploying child stack in pipelines.
With role name, the ARN can be easily constructed (refer readme for importing role) and it provides a better user experience.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license