Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-route53): add CNAME record type #1420

Closed
wants to merge 1 commit into from
Closed

feat(aws-route53): add CNAME record type #1420

wants to merge 1 commit into from

Conversation

MikeBild
Copy link

Fixes #966

Pull Request Checklist

  • Testing

    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • CLI init template change?: coordinated update of integration tests with team

  • Docs

    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated

  • Title and Description

    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

  • Sensitive Modules (requires 2 PR approvers)

    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@MikeBild MikeBild requested a review from a team as a code owner December 21, 2018 10:47
eladb
eladb reviewed Dec 23, 2018
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

  1. Please add jsdocs to all public elements in your code
  2. Please add a unit test to verify the various options and defaults
  3. Please update README of the module with documentation

eladb pushed a commit that referenced this pull request Jan 7, 2019
feat(route53): support CNAME records
019af24 
Adds support for CNAME records via the `CnameRecord` construct.

Misc:

- TXTRecord is deprecated in favor of TxtRecord.
- hostedZoneNameServers attribute added to IHostedZone
- Made HostedZone concrete (non-abstract) so it will be
  compatible with how CloudFormation represents this resource,
  but left PublicHostedZone and PrivateHostedZone to allow
  a more strongly-typed experience if you like.

credits for original PR (closes #1420): @MikeBild
@eladb eladb mentioned this pull request Jan 7, 2019
Merged
4 tasks
@eladb
Copy link
Contributor

eladb commented Jan 7, 2019

Superseded by #1487

@eladb eladb closed this Jan 7, 2019
eladb pushed a commit that referenced this pull request Jan 8, 2019
feat(route53): support CNAME records (#1487)
17eddd1 
Adds support for CNAME records via the `CnameRecord` construct.

Misc:

- `TXTRecord` was renamed to `TxtRecord`.
- `hostedZoneNameServers` attribute added to IHostedZone
- Made `HostedZone` a concrete (non-abstract) class so it will be
  compatible with how CloudFormation represents this resource,
  but left PublicHostedZone and PrivateHostedZone to allow
  a more strongly-typed experience if you like.

Credits for original PR (closes #1420): @MikeBild

BREAKING CHANGE: The `route53.TXTRecord` class was renamed to `route53.TxtRecord`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route 53 L2 construct can't create A records or Alias records
2 participants
@MikeBild @eladb