Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(route53): support CNAME records #1487

Merged
merged 7 commits into from
Jan 8, 2019
Merged

feat(route53): support CNAME records #1487

merged 7 commits into from
Jan 8, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jan 7, 2019 •
edited
Loading

Adds support for CNAME records via the CnameRecord construct.

Misc:

  • TXTRecord was renamed to TxtRecord.
  • hostedZoneNameServers attribute added to IHostedZone
  • Made HostedZone a concrete (non-abstract) class so it will be
    compatible with how CloudFormation represents this resource,
    but left PublicHostedZone and PrivateHostedZone to allow
    a more strongly-typed experience if you like.

Credits for original PR (closes #1420): @MikeBild

BREAKING CHANGE: The route53.TXTRecord class was renamed to route53.TxtRecord.

Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

MikeBild and others added 4 commits December 21, 2018 11:45
@MikeBild
feat(aws-route53): add CNAME record type
463c7d1
Merge remote-tracking branch 'origin/master' into cname
48a1cb8
feat(route53): support CNAME records
019af24 
Adds support for CNAME records via the `CnameRecord` construct.

Misc:

- TXTRecord is deprecated in favor of TxtRecord.
- hostedZoneNameServers attribute added to IHostedZone
- Made HostedZone concrete (non-abstract) so it will be
  compatible with how CloudFormation represents this resource,
  but left PublicHostedZone and PrivateHostedZone to allow
  a more strongly-typed experience if you like.

credits for original PR (closes #1420): @MikeBild
Merge remote-tracking branch 'origin/master' into benisrae/route53-cname
b115d15
@eladb eladb requested a review from a team as a code owner January 7, 2019 13:16
@eladb eladb mentioned this pull request Jan 7, 2019
Closed
4 tasks
@MikeBild
Copy link

MikeBild commented Jan 7, 2019

Very well! 👍

rix0rrr
rix0rrr approved these changes Jan 7, 2019
View reviewed changes
packages/@aws-cdk/aws-route53/lib/records/cname.ts Show resolved Hide resolved
packages/@aws-cdk/aws-route53/lib/records/cname.ts

export interface CnameRecordProps {
zone: IHostedZone;
recordName: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. thanks

RomainMuller
RomainMuller approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@eladb eladb merged commit 17eddd1 into master Jan 8, 2019
@eladb eladb deleted the benisrae/route53-cname branch January 8, 2019 06:56
@shivlaks shivlaks mentioned this pull request Aug 26, 2019
Closed
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eladb @MikeBild @RomainMuller @rix0rrr @NGL321