Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-kinesisfirehose): DeliveryStream API and basic S3 destination #15544

Merged
merged 58 commits into from
Jul 23, 2021
Merged

feat(aws-kinesisfirehose): DeliveryStream API and basic S3 destination #15544

merged 58 commits into from
Jul 23, 2021

Commits on Jul 14, 2021

  1. feat(aws-kinesisfirehose): DeliveryStream API and basic S3 destination

    @madeline-k
    madeline-k committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    8401fb4 View commit details
    Browse the repository at this point in the history

  2. fix typo in aws-kinesisfirehose-destinations README

    @madeline-k
    madeline-k committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    dca12f2 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary deps

    @madeline-k
    madeline-k committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    6fceebf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into madeline-k/feat/kinesisfirehose-deliveryst… 

    …ream
    @madeline-k
    madeline-k committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    7892f58 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. remove awslint exception for IConnectable.connections

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    78e6a9c View commit details
    Browse the repository at this point in the history

  2. Change name of S3 destination to S3Bucket

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    5f7a15c View commit details
    Browse the repository at this point in the history

  3. add Role to DestinationBindOptions, update S3 to S3Bucket in tests

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    efe2fe0 View commit details
    Browse the repository at this point in the history

  4. remove helper function to enforce ExtendedS3DestinationConfigurationP… 

    …roperty type and use local var instead
    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    4308f44 View commit details
    Browse the repository at this point in the history

  5. remove lambda dependency

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    172ab43 View commit details
    Browse the repository at this point in the history

  6. update README

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    c0d85f5 View commit details
    Browse the repository at this point in the history

  7. remove tagsand ITaggable interface

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    3d34c46 View commit details
    Browse the repository at this point in the history

  8. use splitArn instead of parseArn

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    5ceff5c View commit details
    Browse the repository at this point in the history

  9. update error message for bad input ARN

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    ce4dde1 View commit details
    Browse the repository at this point in the history

  10. add ArnFormat to formatArn() call

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    0ed658f View commit details
    Browse the repository at this point in the history

  11. update error message in tests for bad input ARN

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    1925560 View commit details
    Browse the repository at this point in the history

  12. pass deliveryStreamName as physicalName through to super constructor

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    e46c595 View commit details
    Browse the repository at this point in the history

  13. move validation to beginning of constructor

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    d1463a2 View commit details
    Browse the repository at this point in the history

  14. simplify createLoggingOptions

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    1623199 View commit details
    Browse the repository at this point in the history

  15. remove awslint exclude

    @madeline-k
    madeline-k committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    16a54e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. feat(aws-kinesisfirehose): specific metrics functions for DeliveryStr… 

    …eam (#15545)

Closes #15543 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @madeline-k
    madeline-k committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    b011392 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. change name of s3 destination props to S3BucketProps

    @BenChaimberg
    BenChaimberg committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    56aa16a View commit details
    Browse the repository at this point in the history

  2. remove basic s3 integration test

    @BenChaimberg
    BenChaimberg committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    f70fc31 View commit details
    Browse the repository at this point in the history

  3. rename integration tests

    @BenChaimberg
    BenChaimberg committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    73f1777 View commit details
    Browse the repository at this point in the history

  4. de-exports DeliveryStreamBase

    @BenChaimberg
    BenChaimberg committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    314c4ca View commit details
    Browse the repository at this point in the history

  5. leverage construct tree to store LogGroup and prevent creating it mul… 

    …tiple times
    @madeline-k
    madeline-k committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    64131d1 View commit details
    Browse the repository at this point in the history

  6. Revert "feat(aws-kinesisfirehose): specific metrics functions for Del… 

    …iveryStream (#15545)"

This reverts commit b011392.
    @madeline-k
    madeline-k committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    6c78eeb View commit details
    Browse the repository at this point in the history

  7. cleanup s3 destination unit tests to do less hardcoding

    @BenChaimberg
    BenChaimberg committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    ccd9333 View commit details
    Browse the repository at this point in the history

  8. make snippets compile and enforce strict compilation

    @BenChaimberg
    BenChaimberg committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    e37d8ea View commit details
    Browse the repository at this point in the history

  9. remove IDeliveryStream from DestinationBindOptions, only service role… 

    … needed
    @BenChaimberg
    BenChaimberg committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    cd1618b View commit details
    Browse the repository at this point in the history

  10. remove explicit dependency delivery stream -> service role 

    unneeded for this PR and also should set dependencies on individual grants
    @BenChaimberg
    BenChaimberg committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    bfe6dd4 View commit details
    Browse the repository at this point in the history

  11. Revert "remove explicit dependency delivery stream -> service role" 

    This reverts commit bfe6dd4.
    @BenChaimberg
    BenChaimberg committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    dcd088d View commit details
    Browse the repository at this point in the history

  12. destination has separate role

    @BenChaimberg
    BenChaimberg committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    0a7e010 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. update @types/jest dependency to match all other modules

    @madeline-k
    madeline-k committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    c99c242 View commit details
    Browse the repository at this point in the history

  2. loose snippet compilation to avoid cyclic dependency

    @BenChaimberg
    BenChaimberg committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    157d3ca View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into madeline-k/feat/kin… 

    …esisfirehose-deliverystream
    @BenChaimberg
    BenChaimberg committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    49c184d View commit details
    Browse the repository at this point in the history

  4. update README

    @madeline-k
    madeline-k committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    db9ea21 View commit details
    Browse the repository at this point in the history

  5. Use L1 types in DestinationConfig returned from bind()

    @madeline-k
    madeline-k committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    49a839e View commit details
    Browse the repository at this point in the history

  6. remove DestinationBase, move createLoggingOptions and DestinationProps 

    to dests module
    @BenChaimberg
    BenChaimberg committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    a2c85bd View commit details
    Browse the repository at this point in the history

  7. don't pass role into bind()

    @madeline-k
    madeline-k committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    569ca01 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. feat(kinesisfirehose): destinations can provide resources to be depen… 

    …ded on by the delivery stream (#15676)


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @BenChaimberg
    BenChaimberg committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    a307108 View commit details
    Browse the repository at this point in the history

  2. remove unused custom-resources dependency

    @BenChaimberg
    BenChaimberg committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    04d5ae7 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. rewrite providing IAM role section (include separate destination role… 

    …, update example)
    @BenChaimberg
    BenChaimberg committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    93cc0e5 View commit details
    Browse the repository at this point in the history

  2. add more IAM role detail

    @BenChaimberg
    BenChaimberg committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    3aa77bd View commit details
    Browse the repository at this point in the history

  3. snapshot spacing

    @BenChaimberg
    BenChaimberg committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    7883929 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into madeline-k/feat/kin… 

    …esisfirehose-deliverystream
    @BenChaimberg
    BenChaimberg committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    1c65da6 View commit details
    Browse the repository at this point in the history

  5. make s3 destination props readonly

    @BenChaimberg
    BenChaimberg committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    45fec81 View commit details
    Browse the repository at this point in the history

  6. line length linting

    @BenChaimberg
    BenChaimberg committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    28c120f View commit details
    Browse the repository at this point in the history

  7. do not re-use log group if log group provided in props

    @BenChaimberg
    BenChaimberg committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    005402c View commit details
    Browse the repository at this point in the history

  8. rename DestinationProps -> CommonDestinationProps

    @BenChaimberg
    BenChaimberg committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    0f9d42d View commit details
    Browse the repository at this point in the history

  9. move logging tests to S3 bucket destination

    @BenChaimberg
    BenChaimberg committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    ed02d9f View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Merge branch 'master' into madeline-k/feat/kinesisfirehose-deliveryst… 

    …ream
    @madeline-k
    madeline-k committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    c6a8553 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:aws/aws-cdk into madeline-k/feat/… 

    …kinesisfirehose-deliverystream
    @BenChaimberg
    BenChaimberg committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    2bcc663 View commit details
    Browse the repository at this point in the history

  3. use new lazy mappings for CIDR blocks

    @BenChaimberg
    BenChaimberg committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    98d6371 View commit details
    Browse the repository at this point in the history

  4. update S3 -> S3Bucket class name in default.ts-fixture

    @madeline-k
    madeline-k committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    e006441 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Adam Ruka <adamruka@amazon.com>
    @madeline-k @skinny85
    madeline-k and skinny85 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    86c7cb7 View commit details
    Browse the repository at this point in the history

  6. remove private index.ts

    @madeline-k
    madeline-k committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    f8b03c4 View commit details
    Browse the repository at this point in the history

  7. hardcode logical IDs in unit tests

    @madeline-k
    madeline-k committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    8c2903e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into madeline-k/feat/kinesisfirehose-deliveryst… 

    …ream
    @madeline-k
    madeline-k committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    efb6eee View commit details
    Browse the repository at this point in the history